Fix TUI repair and navigation smoke regressions#262
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 21 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe PR remaps lowercase Changesl/L Key Remapping: Navigation vs Library
Daemon Dead-Service State Retention
Dashboard Launch Env and Build Stamp
Runtime Guard Repair Launch and Runtime Restart Tmux Projects
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/daemon.ts`:
- Around line 417-420: The retained project entries in the daemon state are
being treated as proof of liveness by existing readers, which is causing crashed
services to still look alive. Update the handling around state.projects in
src/daemon.ts so retained/dead records are stored separately from the
live-service map, or change the consumers in routeRequest("/projects") and the
daemon status logic in src/main.ts to determine liveness from an actual runtime
check instead of mere map presence. Ensure the symbols projects, liveById, and
routeRequest("/projects") no longer imply “alive” just because an entry exists.
In `@src/dashboard/command-spec.test.ts`:
- Around line 35-40: The dashboard command test only checks that env names are
absent from the command string, which can miss inherited variables; update the
assertions in command-spec.test around spec.dashboardCommand to verify the
command explicitly unsets AIMUX_CLI_BIN and AIMUX_INSTALL_ROOT, while still
asserting the hardcoded path values are not embedded. Keep the existing checks
for AIMUX_HOME and spec.scriptPath so the test validates both the unset flags
and the absence of baked-in values.
In `@src/dashboard/command-spec.ts`:
- Around line 37-49: The current-entry dashboard flow only removes AIMUX_CLI_BIN
and AIMUX_INSTALL_ROOT from the generated env prefix, but those variables still
inherit from the parent shell and can leak stable-shim state. Update
buildDashboardEnvCommandPrefix and dashboardEnvForLaunch so the current-entry
path explicitly unsets these variables in both the launch command and the stamp
command, while keeping stable-shim behavior unchanged. Use the existing
buildDashboardEnvCommandPrefix, dashboardEnvForLaunch, and
DASHBOARD_ENV_KEYS/DASHBOARD_ENV_STAMP_DEFAULTS logic to locate and apply the
fix.
In `@src/multiplexer/dashboard-control.ts`:
- Line 496: Move the resolveDashboardReloadLaunch(projectRoot) call back inside
the existing repair try/catch in dashboard control so any exception is handled
by the repair flow. Keep the lock acquisition and the launch resolution within
the same guarded block used by the repair logic, and ensure fail() is still
invoked on errors from resolveDashboardReloadLaunch. Refer to the repair path in
dashboard-control and the resolveDashboardReloadLaunch helper when making the
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 920656ec-f66e-43a9-9607-6fbf314d05fe
📒 Files selected for processing (23)
src/daemon.test.tssrc/daemon.tssrc/dashboard/command-spec.test.tssrc/dashboard/command-spec.tssrc/key-parser.tssrc/multiplexer/archives.tssrc/multiplexer/coordination.tssrc/multiplexer/dashboard-actions-methods.tssrc/multiplexer/dashboard-control.test.tssrc/multiplexer/dashboard-control.tssrc/multiplexer/dashboard-interaction.test.tssrc/multiplexer/dashboard-interaction.tssrc/multiplexer/library.tssrc/multiplexer/navigation.tssrc/multiplexer/project.tssrc/multiplexer/runtime-guard.test.tssrc/multiplexer/topology.tssrc/runtime-restart.test.tssrc/runtime-restart.tssrc/tui/screens/dashboard-renderers.test.tssrc/tui/screens/dashboard-renderers.tssrc/tui/screens/overlay-renderers.tssrc/tui/screens/subscreen-renderers.ts
Summary
lnavigation and move Library shortcuts to uppercaseLVerification
doctor versionspassedSummary by CodeRabbit
New Features
las an alias for opening/entering sections, and the help/footer hints reflect the updated shortcuts.Lin shortcut guidance.Bug Fixes