Harden project thread resource lifecycle - #335
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR introduces a Jotai-backed resource model for project threads ( ChangesProject threads resource and refresh migration
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant ThreadsScreen
participant beginProjectThreadsRefreshAtom
participant API
participant applyProjectThreadsSuccessAtom
participant projectThreadsResourceFamily
ThreadsScreen->>beginProjectThreadsRefreshAtom: begin refresh with requestKey
ThreadsScreen->>API: fetch threads
API-->>ThreadsScreen: response
ThreadsScreen->>applyProjectThreadsSuccessAtom: apply success with requestKey
applyProjectThreadsSuccessAtom->>projectThreadsResourceFamily: update value if requestKey matches pendingRequestKey
projectThreadsResourceFamily-->>ThreadsScreen: render visibleThreads/visibleError
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
app/app/(main)/(tabs)/(threads)/threads.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. app/app/(main)/(tabs)/project/index.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. app/stores/project.test.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.
Comment |
Summary
Verification
Summary by CodeRabbit
New Features
Bug Fixes