Cut agent resume to topology authority - #351
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds internal helpers ChangesTopology-authoritative offline session pruning
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/multiplexer/runtime-state.ts (1)
78-83: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winImport
RuntimeTopologySessionStatusinstead of repeating the union.
findTopologySessionshould use the sharedRuntimeTopologySessionStatusexport fromsrc/runtime-core/topology-sessions.tsinstead of duplicating the status list inline. That keeps this helper aligned with the canonical session state contract.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/multiplexer/runtime-state.ts` around lines 78 - 83, findTopologySession is duplicating the topology session status union inline instead of using the shared RuntimeTopologySessionStatus type. Update the statuses parameter in findTopologySession to reference RuntimeTopologySessionStatus from src/runtime-core/topology-sessions.ts, and keep the listTopologySessionStates call unchanged so the helper stays aligned with the canonical session-state contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/multiplexer/runtime-state.ts`:
- Around line 78-83: findTopologySession is duplicating the topology session
status union inline instead of using the shared RuntimeTopologySessionStatus
type. Update the statuses parameter in findTopologySession to reference
RuntimeTopologySessionStatus from src/runtime-core/topology-sessions.ts, and
keep the listTopologySessionStates call unchanged so the helper stays aligned
with the canonical session-state contract.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 87fa066b-168b-4130-a849-90971a594354
📒 Files selected for processing (2)
src/multiplexer/runtime-state.test.tssrc/multiplexer/runtime-state.ts
Summary
Verification
Summary by CodeRabbit