chore: close core sidecar north star tracker - #357
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR refactors plan progress polling to source data from a new ChangesPlan authority routing
North-star completion documentation and verification
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/verify-north-star-tracker.mjs (1)
52-104: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winValidate the expected epic and snapshot labels, not just counts.
Right now this accepts any 10
Status:lines and any 12 table rows markedDone, so a duplicated or renamed epic/area could still pass CI. Please lock the checks to the explicit A–J epic set and the expected Executive Snapshot area names.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/verify-north-star-tracker.mjs` around lines 52 - 104, The verification script in verify-north-star-tracker.mjs is only checking counts, which can let duplicated or renamed epic/snapshot entries pass. Tighten the validation around the existing epic status parsing and Executive Snapshot row checks by verifying the exact A–J epic set and the expected area names, not just that there are 10 statuses and 12 Done rows. Use the current trackerText scanning logic, epicStatuses loop, and the Executive Snapshot table parsing to assert the labels match the fixed expected values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@scripts/verify-north-star-tracker.mjs`:
- Around line 52-104: The verification script in verify-north-star-tracker.mjs
is only checking counts, which can let duplicated or renamed epic/snapshot
entries pass. Tighten the validation around the existing epic status parsing and
Executive Snapshot row checks by verifying the exact A–J epic set and the
expected area names, not just that there are 10 statuses and 12 Done rows. Use
the current trackerText scanning logic, epicStatuses loop, and the Executive
Snapshot table parsing to assert the labels match the fixed expected values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c0c3b8f6-ccd7-4436-9e27-9999af93b3f0
📒 Files selected for processing (7)
docs/core-sidecar-north-star.mddocs/north-star-completion-tracker.mdscripts/verify-north-star-tracker.mjssrc/builtin-metadata-watchers.test.tssrc/builtin-metadata-watchers.tssrc/runtime-core/plan-authority.tssrc/runtime-exchange-boundary.test.ts
💤 Files with no reviewable changes (1)
- src/runtime-exchange-boundary.test.ts
|
Deployment failed with the following error: Learn More: https://vercel.com/sams-projects-de5e5436?upgradeToPro=build-rate-limit |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
CodeRabbit summary fixed in a6640bf: the north-star verifier now checks the exact Epic A-J headings and the exact Executive Snapshot row names/order, not just counts. |
Summary
Verification
Summary by CodeRabbit
Documentation
Tests