Skip to content

chore: close core sidecar north star tracker - #357

Merged
TraderSamwise merged 3 commits into
masterfrom
chore/core-sidecar-next-82
Jul 7, 2026
Merged

chore: close core sidecar north star tracker#357
TraderSamwise merged 3 commits into
masterfrom
chore/core-sidecar-next-82

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • mark the core-sidecar north-star completion tracker as Done across all ten epics and all executive snapshot areas
  • update the north-star overview from migration backlog wording to completed-architecture maintenance guidance
  • route metadata watcher plan-progress reads through plan authority and tighten the runtime exchange boundary guard
  • strengthen the north-star verifier so unchecked items, non-Done statuses, stale overview wording, and bad snapshot rows fail

Verification

  • yarn verify:north-star
  • yarn vitest src/builtin-metadata-watchers.test.ts src/runtime-exchange-boundary.test.ts
  • yarn vitest src/core-command-ownership.test.ts src/installed-shim.test.ts src/one-shot-node-inventory.test.ts src/project-api-contract.test.ts src/multiplexer/tui-api-boundary.test.ts src/runtime-authority-contract.test.ts src/runtime-projection-contract.test.ts
  • yarn typecheck
  • yarn lint --max-warnings=0
  • yarn test
  • yarn verify:app
  • yarn verify
  • yarn release:readiness

Summary by CodeRabbit

  • Documentation

    • Updated completion tracking docs to reflect that the core architecture and milestone checklist are now complete, with clearer status sections and a maintenance-oriented framing.
    • Added stronger cross-references and evidence notes for completion claims.
  • Tests

    • Tightened verification checks so incomplete tracker items, outdated wording, or missing status sections now fail validation.
    • Expanded coverage to ensure plan progress is read through the approved runtime path and remains consistent in tests.

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jul 7, 2026 7:35am

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: da0cd454-ef3e-451a-b51c-b7673679f184

📥 Commits

Reviewing files that changed from the base of the PR and between 8bffc17 and a6640bf.

📒 Files selected for processing (2)
  • docs/north-star-completion-tracker.md
  • scripts/verify-north-star-tracker.mjs
📝 Walkthrough

Walkthrough

This PR refactors plan progress polling to source data from a new listPlanAuthorityEntries() helper in the plan-authority module instead of directly reading plan markdown files, updates related tests and boundary allowlists, and marks north-star documentation (overview and completion tracker) as fully done, tightening the verification script accordingly.

Changes

Plan authority routing

Layer / File(s) Summary
listPlanAuthorityEntries helper
src/runtime-core/plan-authority.ts
Adds a new exported function that lists .md plan files, validates session IDs, and returns {sessionId, content} entries, excluding missing content.
Metadata watcher wiring
src/builtin-metadata-watchers.ts, src/builtin-metadata-watchers.test.ts, src/runtime-exchange-boundary.test.ts
Plan watcher now iterates listPlanAuthorityEntries() instead of manually reading plan files; tests seed plans via writePlanContent; boundary allowlist tightened to remove the non-test watcher file.

North-star completion documentation and verification

Layer / File(s) Summary
Core sidecar overview updates
docs/core-sidecar-north-star.md
Replaces "Current Focus" with "Completion State," renames "Current Progress" to "Completed Architecture," tightens wording, and adds a "Maintenance Path" section.
Completion tracker epics marked Done
docs/north-star-completion-tracker.md
Updates Executive Snapshot table and all nine completion epics from partial/remaining to Done with completed checklists, evidence sections, and a new scorecard row.
Verification script enforcement
scripts/verify-north-star-tracker.mjs
Adds checks for required headings/links, fails on unchecked items or stale wording, and validates epic statuses and snapshot rows are all Done.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • TraderSamwise/aimux#340: Introduced the same north-star completion/release-readiness gate now enforced further in scripts/verify-north-star-tracker.mjs and docs/north-star-completion-tracker.md.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: closing the core sidecar north-star tracker and related completion updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/core-sidecar-next-82

Comment @coderabbitai help to get the list of available commands.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
scripts/verify-north-star-tracker.mjs (1)

52-104: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Validate the expected epic and snapshot labels, not just counts.

Right now this accepts any 10 Status: lines and any 12 table rows marked Done, so a duplicated or renamed epic/area could still pass CI. Please lock the checks to the explicit A–J epic set and the expected Executive Snapshot area names.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/verify-north-star-tracker.mjs` around lines 52 - 104, The
verification script in verify-north-star-tracker.mjs is only checking counts,
which can let duplicated or renamed epic/snapshot entries pass. Tighten the
validation around the existing epic status parsing and Executive Snapshot row
checks by verifying the exact A–J epic set and the expected area names, not just
that there are 10 statuses and 12 Done rows. Use the current trackerText
scanning logic, epicStatuses loop, and the Executive Snapshot table parsing to
assert the labels match the fixed expected values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@scripts/verify-north-star-tracker.mjs`:
- Around line 52-104: The verification script in verify-north-star-tracker.mjs
is only checking counts, which can let duplicated or renamed epic/snapshot
entries pass. Tighten the validation around the existing epic status parsing and
Executive Snapshot row checks by verifying the exact A–J epic set and the
expected area names, not just that there are 10 statuses and 12 Done rows. Use
the current trackerText scanning logic, epicStatuses loop, and the Executive
Snapshot table parsing to assert the labels match the fixed expected values.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c0c3b8f6-ccd7-4436-9e27-9999af93b3f0

📥 Commits

Reviewing files that changed from the base of the PR and between 46e3a51 and 8bffc17.

📒 Files selected for processing (7)
  • docs/core-sidecar-north-star.md
  • docs/north-star-completion-tracker.md
  • scripts/verify-north-star-tracker.mjs
  • src/builtin-metadata-watchers.test.ts
  • src/builtin-metadata-watchers.ts
  • src/runtime-core/plan-authority.ts
  • src/runtime-exchange-boundary.test.ts
💤 Files with no reviewable changes (1)
  • src/runtime-exchange-boundary.test.ts

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/sams-projects-de5e5436?upgradeToPro=build-rate-limit

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

CodeRabbit summary fixed in a6640bf: the north-star verifier now checks the exact Epic A-J headings and the exact Executive Snapshot row names/order, not just counts.

@TraderSamwise
TraderSamwise merged commit f72dda4 into master Jul 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant