Stop creating AGENTS.md by default - #44
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR makes instruction-file projection opt-in (disabled by default), removes codex defaults that auto-create ChangesInstruction File Opt-in Configuration and Contract
Instruction File Cleanup Implementation
Cleanup Behavior Test Coverage
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/multiplexer/runtime-lifecycle-methods.ts`:
- Around line 65-75: cleanupManagedInstructionFile performs file I/O and can
throw, but writeInstructionFiles calls it without protection; wrap the call to
cleanupManagedInstructionFile inside writeInstructionFiles in a try/catch
(similar to removeInstructionFiles) and handle failures gracefully (e.g., log
the error via the existing logger or swallow non-fatal errors) so a failed
cleanup during write doesn't crash the runtime.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 65279fc7-4aa5-4d36-998a-fa6cc3380d2f
📒 Files selected for processing (5)
README.mddocs/tool-integration.mdsrc/config.tssrc/multiplexer/runtime-lifecycle-methods.test.tssrc/multiplexer/runtime-lifecycle-methods.ts
Summary
instructionsFile: "AGENTS.md"so aimux no longer creates repo instruction files by defaultdeveloper_instructions, with file projection only as explicit opt-in configAGENTS.mdblocks from the legacy default path while preserving user-authored files without Aimux markersVerification
Summary by CodeRabbit
Documentation
Bug Fixes
Chores
Tests