Test context bridge parser regressions#72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Too much diff to scan? Review this PR in Change Stack to start with the highest-impact changes. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a shared parser-fixture helper and updates tests to use named fixtures; introduces two ContextWatcher tests validating that Codex startup suggestion loops are not recorded and Claude tool-action rows are excluded from captured response turns. ChangesContextWatcher response exclusion tests
Sequence Diagram(s)sequenceDiagram
participant Test
participant getParserFixture
participant ContextWatcher
participant Assertion
Test->>getParserFixture: fetch fixture by name
getParserFixture->>Test: return raw fixture output
Test->>ContextWatcher: feed raw output to capture
ContextWatcher->>Assertion: provide readHistory for session
Assertion->>Test: verify recorded turns / exclusions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/context/context-bridge.test.ts`:
- Around line 20-24: Extract the duplicated parserFixture logic into a shared
test utility function (e.g., getParserFixture in a new fixture-helpers module)
that imports AGENT_OUTPUT_PARSER_FIXTURES and performs the same find/throw
behavior, then replace the local parserFixture implementation in both
context-bridge.test.ts (parserFixture) and agent-output-parser-harness.test.ts
with an import of the shared getParserFixture; ensure the error message and
behavior remain identical so tests keep the same semantics.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e6a1997f-94b5-441b-9a52-108d7b8d3766
📒 Files selected for processing (1)
src/context/context-bridge.test.ts
Summary
Verification
Summary by CodeRabbit
Note: Internal testing improvements only; no user-visible changes.