Skip to content

Test parser action status wording - #77

Merged
TraderSamwise merged 1 commit into
masterfrom
test/chat-parser-state-machine-audit
Jun 6, 2026
Merged

Test parser action status wording#77
TraderSamwise merged 1 commit into
masterfrom
test/chat-parser-state-machine-audit

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • add parser contract coverage for activity/spinner status wording
  • add parser contract coverage for Claude tool action rows staying status
  • assert tool/action status rows are not assistant chat responses

Verification

  • vitest run src/agent-output-parser.test.ts
  • tsc --noEmit
  • eslint src/ --max-warnings=0
  • yarn build
  • vitest run

Summary by CodeRabbit

  • Tests
    • Added test coverage for output parsing functionality to improve code reliability and validation.

@vercel

vercel Bot commented Jun 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 6, 2026 10:51am

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Looking for one thing? Review this PR in Change Stack to search files, summaries, diffs, and code without losing your place.

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7c90f33f-98c9-4354-bcf2-39019e8cabac

📥 Commits

Reviewing files that changed from the base of the PR and between e8de9bd and a6f40f3.

📒 Files selected for processing (1)
  • src/agent-output-parser.test.ts

📝 Walkthrough

Walkthrough

Two new test cases extend coverage of parseAgentOutput to validate Claude activity spinner row parsing into status blocks with preserved multi-row formatting, and Claude tool/action label segmentation with correct block ordering and multiline status text retention.

Changes

Agent Output Parser Test Coverage

Layer / File(s) Summary
Claude spinner and tool action parsing tests
src/agent-output-parser.test.ts
Two new Vitest cases verify that Claude activity spinner text (e.g., working/cooked/brewed/worked) is parsed as status blocks with multi-row text combined using blank-line separators, and that Claude tool/action rows (including "⏺ …" lines, indented continuation, and subsequent tool labels) are segmented into response/status blocks with preserved indentation and line breaks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • TraderSamwise/aimux#67: New test cases validate Claude activity/spinner row detection and status text formatting, aligning directly with parser contract changes for activity row invariants.
  • TraderSamwise/aimux#71: Both PRs extend coverage of Claude spinner/tool-action rows (including "⏺"-style action lines and multi-line status text) in the parseAgentOutput parser.
  • TraderSamwise/aimux#73: Both PRs validate parseAgentOutput block segmentation for Claude status-and-tool rows at the parser contract level.

Poem

A rabbit hops through spinner rows,
Tool actions dance in parsed compose.
Multi-line status, preserved whole—
The parser knows its Claude-bound role.
Tests bloom bright to light the way. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Test parser action status wording' is directly related to the main change: adding test cases for parsing Claude activity spinner text and tool action rows as status blocks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/chat-parser-state-machine-audit

Comment @coderabbitai help to get the list of available commands and usage tips.

@TraderSamwise
TraderSamwise merged commit 0add3c3 into master Jun 6, 2026
3 checks passed
@TraderSamwise
TraderSamwise deleted the test/chat-parser-state-machine-audit branch June 6, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant