Route teammate work through durable tasks#8
Merged
Conversation
added 10 commits
May 22, 2026 08:17
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR migrates defaults to aimux.app and raises Node.js requirement to 22, centralizes project HTTP calls via a relay-aware helper, adds chat relay polling, converts teammate delegation to durable tasks (new /agents/teammates/tasks and initialTask), retires the old send route, and refactors tmux prompt submission to await acceptance with updated tests. ChangesRelay-driven architecture with durable teammate tasks and Node.js 22
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/metadata-server.ts (1)
2213-2224:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winValidate empty
teammateSessionIdas a 400 input error.An empty
teammateSessionIdcurrently falls through to the "not attached" 404 path, which is misleading for malformed input.💡 Suggested fix
const parentSessionId = body.parentSessionId?.trim() ?? ""; const teammateSessionId = body.teammateSessionId?.trim() ?? ""; +if (!teammateSessionId) { + send(res, 400, { ok: false, error: "teammateSessionId is required" }); + return; +} const resolved = this.resolveDirectTeammates(parentSessionId);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/metadata-server.ts` around lines 2213 - 2224, The code currently treats an empty teammateSessionId as "not attached" resulting in a 404; add an explicit validation immediately after computing teammateSessionId (the variable from body.teammateSessionId?.trim() ?? "") to check for an empty string and call send(res, 400, { ok: false, error: "missing or empty teammateSessionId" }) (or similar input-error message) before calling resolveDirectTeammates() / searching via resolved.teammates in resolveDirectTeammates and before the teammate lookup so malformed input yields a 400 instead of a 404.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/metadata-server.ts`:
- Around line 493-495: The current logic in teammateTaskDescription uses
body.body even when it's only whitespace, causing it to ignore a valid prompt;
update the text selection so that text = typeof body.body === "string" &&
body.body.trim() !== "" ? body.body.trim() : prompt (or equivalent) so that an
empty/whitespace body falls back to prompt before computing firstLine(text) and
slicing to 120 chars.
---
Outside diff comments:
In `@src/metadata-server.ts`:
- Around line 2213-2224: The code currently treats an empty teammateSessionId as
"not attached" resulting in a 404; add an explicit validation immediately after
computing teammateSessionId (the variable from body.teammateSessionId?.trim() ??
"") to check for an empty string and call send(res, 400, { ok: false, error:
"missing or empty teammateSessionId" }) (or similar input-error message) before
calling resolveDirectTeammates() / searching via resolved.teammates in
resolveDirectTeammates and before the teammate lookup so malformed input yields
a 400 instead of a 404.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a2c23bfe-4993-4c4d-a4b4-2aef2179f03f
📒 Files selected for processing (31)
.env.exampleREADME.mdapp/.env.exampleapp/app.config.jsapp/app/(main)/agent/[sessionId]/chat.tsxapp/lib/api.test.tsapp/lib/api.tsapp/package.jsonapp/vercel.jsondocs/deployment.mdpackage.jsonrelay/wrangler.tomlscripts/install.shsrc/config.test.tssrc/config.tssrc/login-flow.tssrc/main.tssrc/metadata-server.test.tssrc/metadata-server.tssrc/multiplexer/dashboard-model.test.tssrc/multiplexer/dashboard-model.tssrc/multiplexer/dashboard-tail-methods.tssrc/multiplexer/session-actions.test.tssrc/multiplexer/session-actions.tssrc/multiplexer/session-runtime-core.test.tssrc/multiplexer/session-runtime-core.tssrc/relay-client.test.tssrc/session-bootstrap.test.tssrc/session-bootstrap.tssrc/task-dispatcher.test.tssrc/task-workflow.ts
💤 Files with no reviewable changes (6)
- src/multiplexer/dashboard-model.test.ts
- src/multiplexer/dashboard-tail-methods.ts
- app/app.config.js
- src/multiplexer/session-actions.test.ts
- src/multiplexer/dashboard-model.ts
- src/multiplexer/session-actions.ts
Owner
Author
|
Fixed in 424ca99 - empty teammateSessionId is now rejected as a 400 input error before teammate lookup, and coverage was added for that path. |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Summary by CodeRabbit
New Features
Documentation
Chores
Refactor