Skip to content

Test parser status-only transcript rendering - #80

Merged
TraderSamwise merged 1 commit into
masterfrom
test/chat-parser-next-regressions
Jun 6, 2026
Merged

Test parser status-only transcript rendering#80
TraderSamwise merged 1 commit into
masterfrom
test/chat-parser-next-regressions

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • promote malformed Claude animation and collapsed approval captures into shared parser fixtures
  • verify app transcript conversion renders those status-only captures as zero chat messages

Verification

  • vitest run src/agent-output-parser-fixtures.test.ts src/agent-output-parser.test.ts
  • tsc --noEmit
  • eslint src/ --max-warnings=0
  • app parsed-transcript vitest/tsc/eslint with temporary dependency symlink
  • yarn build
  • vitest run

Summary by CodeRabbit

  • Tests
    • Expanded test coverage for edge cases involving Claude artifacts to verify that malformed animation captures and collapsed approval statuses are handled correctly and not incorrectly processed into chat messages.

@vercel

vercel Bot commented Jun 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 6, 2026 11:33am

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 25762f37-c13e-4e1e-90a8-6f8542bb7841

📥 Commits

Reviewing files that changed from the base of the PR and between eb3b5cd and 88638dc.

📒 Files selected for processing (2)
  • app/lib/parsed-transcript.test.ts
  • src/agent-output-parser-fixtures.ts

📝 Walkthrough

Walkthrough

This PR adds two new test fixtures and corresponding test cases to verify that specific Claude terminal artifacts (malformed animation captures and collapsed approval captures) are correctly classified as status/metadata blocks rather than converted into chat messages.

Changes

Claude Artifact Non-Conversion Coverage

Layer / File(s) Summary
Fixture definitions and non-conversion assertions
src/agent-output-parser-fixtures.ts, app/lib/parsed-transcript.test.ts
Two new fixtures (claude-malformed-animation-status and claude-collapsed-approval-status) are added to AGENT_OUTPUT_PARSER_FIXTURES, each specifying a raw terminal transcript and expected parsed block types. Corresponding test cases in parsed-transcript.test.ts assert that both fixtures produce empty chat message arrays.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • TraderSamwise/aimux#74: Both PRs extend app/lib/parsed-transcript.test.ts to add fixture-driven assertions that Claude-related transcript artifacts are omitted from chat messages.
  • TraderSamwise/aimux#78: Both PRs address malformed Claude animation/spinner noise by verifying the parser classifies such blocks as metadata/status rather than assistant chat.
  • TraderSamwise/aimux#79: Both PRs address how Claude collapsed approval terminal captures are parsed and classified as status blocks rather than chat messages.

Poem

🐰 Hop, skip, and test with glee,
These Claude artifacts shall never be
Chat messages or noise so sly—
Just status blocks, I swear and sigh. 🎪✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding test cases for parser handling of status-only transcripts, which aligns with promoting fixtures and verifying transcript rendering.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/chat-parser-next-regressions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

app/lib/parsed-transcript.test.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Comment @coderabbitai help to get the list of available commands and usage tips.

@TraderSamwise
TraderSamwise merged commit e5c95ab into master Jun 6, 2026
3 checks passed
@TraderSamwise
TraderSamwise deleted the test/chat-parser-next-regressions branch June 6, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant