Skip to content

Share parser audit flag list - #94

Merged
TraderSamwise merged 1 commit into
masterfrom
test/chat-parser-next-live-audit
Jun 6, 2026
Merged

Share parser audit flag list#94
TraderSamwise merged 1 commit into
masterfrom
test/chat-parser-next-live-audit

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • export the parser audit flag list from the audit module
  • use the shared flag list in the audit CLI instead of duplicating it
  • assert summary counts initialize every supported flag

Verification

  • PATH=/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/.local/volta-shims:/Users/sam/.local/bin:/Users/sam/.bun/bin:/Users/sam/.codex/tmp/arg0/codex-arg0MLlwy8:/Users/sam/.volta/tools/image/packages/@openai/codex/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/opt/homebrew/opt/mysql-client/bin:/Users/sam/opt/anaconda3/envs/py39/bin:/Users/sam/.npm-global/bin:/Users/sam/pathother:/Users/sam/apache-ant/bin:/usr/local/mysql/bin:/Users/sam/.codex/tmp/arg0/codex-arg0FiIdYh:/Applications/cmux.app/Contents/Resources/bin:/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/opt/anaconda3/condabin:/Users/Sam/.npm-global/bin:/Users/Sam/pathother:/Users/Sam/apache-ant/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/pkg/env/global/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:/Users/sam/.cargo/bin:/Users/sam/bin /Users/sam/cs/aimux/node_modules/.bin/vitest run src/agent-output-parser-audit.test.ts src/agent-output-parser.test.ts src/agent-output-parser-fixtures.test.ts src/agent-output-parser-harness.test.ts
  • PATH=/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/.local/volta-shims:/Users/sam/.local/bin:/Users/sam/.bun/bin:/Users/sam/.codex/tmp/arg0/codex-arg0MLlwy8:/Users/sam/.volta/tools/image/packages/@openai/codex/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/opt/homebrew/opt/mysql-client/bin:/Users/sam/opt/anaconda3/envs/py39/bin:/Users/sam/.npm-global/bin:/Users/sam/pathother:/Users/sam/apache-ant/bin:/usr/local/mysql/bin:/Users/sam/.codex/tmp/arg0/codex-arg0FiIdYh:/Applications/cmux.app/Contents/Resources/bin:/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/opt/anaconda3/condabin:/Users/Sam/.npm-global/bin:/Users/Sam/pathother:/Users/Sam/apache-ant/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/pkg/env/global/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:/Users/sam/.cargo/bin:/Users/sam/bin /Users/sam/cs/aimux/node_modules/.bin/tsc --noEmit
  • PATH=/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/.local/volta-shims:/Users/sam/.local/bin:/Users/sam/.bun/bin:/Users/sam/.codex/tmp/arg0/codex-arg0MLlwy8:/Users/sam/.volta/tools/image/packages/@openai/codex/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/opt/homebrew/opt/mysql-client/bin:/Users/sam/opt/anaconda3/envs/py39/bin:/Users/sam/.npm-global/bin:/Users/sam/pathother:/Users/sam/apache-ant/bin:/usr/local/mysql/bin:/Users/sam/.codex/tmp/arg0/codex-arg0FiIdYh:/Applications/cmux.app/Contents/Resources/bin:/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/opt/anaconda3/condabin:/Users/Sam/.npm-global/bin:/Users/Sam/pathother:/Users/Sam/apache-ant/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/pkg/env/global/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:/Users/sam/.cargo/bin:/Users/sam/bin /Users/sam/cs/aimux/node_modules/.bin/eslint src/ --max-warnings=0
  • PATH=/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/cs/aimux/node_modules/.bin:/Users/sam/.local/volta-shims:/Users/sam/.local/bin:/Users/sam/.bun/bin:/Users/sam/.codex/tmp/arg0/codex-arg0MLlwy8:/Users/sam/.volta/tools/image/packages/@openai/codex/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/opt/homebrew/opt/mysql-client/bin:/Users/sam/opt/anaconda3/envs/py39/bin:/Users/sam/.npm-global/bin:/Users/sam/pathother:/Users/sam/apache-ant/bin:/usr/local/mysql/bin:/Users/sam/.codex/tmp/arg0/codex-arg0FiIdYh:/Applications/cmux.app/Contents/Resources/bin:/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/opt/anaconda3/condabin:/Users/Sam/.npm-global/bin:/Users/Sam/pathother:/Users/Sam/apache-ant/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/pkg/env/global/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:/Users/sam/.cargo/bin:/Users/sam/bin yarn audit:parser:strict
  • PATH=/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/.local/volta-shims:/Users/sam/.local/bin:/Users/sam/.bun/bin:/Users/sam/.codex/tmp/arg0/codex-arg0MLlwy8:/Users/sam/.volta/tools/image/packages/@openai/codex/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/opt/homebrew/opt/mysql-client/bin:/Users/sam/opt/anaconda3/envs/py39/bin:/Users/sam/.npm-global/bin:/Users/sam/pathother:/Users/sam/apache-ant/bin:/usr/local/mysql/bin:/Users/sam/.codex/tmp/arg0/codex-arg0FiIdYh:/Applications/cmux.app/Contents/Resources/bin:/Users/sam/.nvm/versions/node/v24.16.0/bin:/Users/sam/opt/anaconda3/condabin:/Users/Sam/.npm-global/bin:/Users/Sam/pathother:/Users/Sam/apache-ant/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/pkg/env/global/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:/Users/sam/.cargo/bin:/Users/sam/bin node scripts/audit-agent-output-parser.mjs --history /Users/sam/cs/aimux/.aimux/history --context /Users/sam/cs/aimux/.aimux/context --fail-on-findings --max 20

Summary by CodeRabbit

  • Refactor

    • Audit flag definitions have been consolidated into a centralized source, eliminating manual configuration duplication and improving code consistency.
  • Tests

    • Added test coverage to ensure audit functionality properly initializes with all supported audit flags as defined in the system.

@vercel

vercel Bot commented Jun 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 6, 2026 2:34pm

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ba8253bc-22da-42e8-81e5-a78922825008

📥 Commits

Reviewing files that changed from the base of the PR and between 8236ba3 and d7fb3a8.

📒 Files selected for processing (3)
  • scripts/audit-agent-output-parser.mjs
  • src/agent-output-parser-audit.test.ts
  • src/agent-output-parser-audit.ts

📝 Walkthrough

Walkthrough

The PR refactors audit flag definitions from scattered hardcoded literals into a single exported constant array. The type and helper function now derive from this constant, and the CLI script and tests consume it consistently.

Changes

Centralize audit flag definitions

Layer / File(s) Summary
Audit flag constant and type definition
src/agent-output-parser-audit.ts
Introduces PARSER_AUDIT_FINDING_FLAGS exported readonly tuple of flag literals, derives ParserAuditFindingFlag type from that tuple, and refactors emptyCounts() to dynamically build the Record<ParserAuditFindingFlag, number> via Object.fromEntries instead of a hardcoded object literal.
CLI and test integration
scripts/audit-agent-output-parser.mjs, src/agent-output-parser-audit.test.ts
CLI script derives allowed --flag values from PARSER_AUDIT_FINDING_FLAGS instead of hardcoding. Test suite verifies that auditAgentOutputParserCorpus({}) initializes countsByFlag with all flag keys defined in the constant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • TraderSamwise/aimux#82: Modifies the same audit flag plumbing in scripts/audit-agent-output-parser.mjs and src/agent-output-parser-audit.ts by introducing a centralized PARSER_AUDIT_FINDING_FLAGS list.
  • TraderSamwise/aimux#81: Follow-up refactor of audit tooling that updates both src/agent-output-parser-audit.ts and related code to use centralized audit flag definitions.
  • TraderSamwise/aimux#88: Changes audit-output parser flag handling in the same locations, introducing new flags and updating parsing behavior alongside the centralization effort.

Poem

🐰 Flags aligned in orderly array,
No hardcodes scattered on the way,
The type derives, the tests confirm—
One source of truth for flags to learn!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Share parser audit flag list' directly and concisely summarizes the main change: exporting the parser audit flag list for reuse instead of duplication.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/chat-parser-next-live-audit

Comment @coderabbitai help to get the list of available commands and usage tips.

@TraderSamwise
TraderSamwise merged commit cf28e57 into master Jun 6, 2026
3 checks passed
@TraderSamwise
TraderSamwise deleted the test/chat-parser-next-live-audit branch June 6, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant