Fix DeepSeek V2 dense MLP hook semantics - #1651
Merged
jlarson4 merged 2 commits intoAug 13, 2026
Merged
Conversation
jlarson4
reviewed
Aug 12, 2026
jlarson4
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking this on @koriyoshi2041! Looks good to me, just one note about a bug in the test suite.
Collaborator
|
Thanks for fixing that up @koriyoshi2041! Great work, merging now |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1645.
DeepSeek V2 uses dense gated MLPs for the prefix selected by
first_k_dense_replace, but the adapter currently gives every layer MoE boundary aliases. This adds optional dense projection bridges and resolves the compatibility aliases togate_proj,up_proj, anddown_projwhen those modules exist, while sparse layers keep their existing block-boundary aliases.The regression coverage checks exact hook identity and width on a tiny dense layer, and verifies that a later sparse layer retains its current behavior.
Tests:
uv run pytest -q tests/unit/model_bridge/supported_architectures/test_deepseek_v2_adapter.py tests/integration/model_bridge/test_deepseek_v2_adapter.py(44 passed)uv run mypy transformer_lens/model_bridge/supported_architectures/deepseek_v2.pymake check-formatgit diff --check