Stabilize Bridge numerical CI tests - #1654
Merged
jlarson4 merged 1 commit intoAug 12, 2026
Merged
Conversation
emerardd
marked this pull request as ready for review
August 12, 2026 09:28
Collaborator
|
Looks great @emerardd, thanks for cleaning this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilize two TransformerBridge integration assertions that cross the numerical envelope of different GitHub-hosted CPU runners. This is independent of the Qwen gated-query change in #1653; that PR exposed the existing baseline failures through its full-coverage run.
The left-padding neighbour test previously compared a three-row batch against separate one-row forwards. Those different matrix shapes can select different CPU/BLAS kernels and produced a
9.1552734375e-05maximum absolute difference despite equivalent position handling. The test now compares two equal-shaped batches that differ only in whether the middle row requires derived positions, isolating the behaviour the regression test is intended to protect.The optimizer parity test used a step-1 post-update mean-logit threshold of
1e-3. Multiple GitHub CPU runners reproducibly report0.0010319872526451945, so this one empirical threshold is recalibrated to2e-3; the initial-forward, maximum-logit, loss, parameter-update, and step-10 thresholds remain unchanged.The exact pair of failures appeared in these unrelated
dev-4.xruns:The current #1653 failure is:
The same base SHA also completed successfully in:
No production code or dependencies are changed.
Type of change
Screenshots
Not applicable.
Checklist:
The documentation change is limited to the affected test docstring and explanatory comment; no user-facing API documentation changes are needed. The full unit suite was not rerun because this PR changes only two integration tests.
Validation
2 passed-n 2 --dist loadscope,OMP_NUM_THREADS=1, andMKL_NUM_THREADS=1:31 passeduv run mypy .:Success: no issues found in 431 source filesgit diff --checkpasses