Skip to content

Allow adding equipment to VehicleType #875

@Robbendebiene

Description

@Robbendebiene

Currently only facilities can be assigned to a VehicleType (via VehicleType/facilities) but not equipment. Equipment requires a DeckPlan element (EquipableSpace) or Vehicle that references it (via actualVehicleEquipments).

In our opinion any equipment that can be assigned to a Vehicle like AccessVehicleEquipment or WheelchairVehicleEquipment, likewise make sense on a VehicleType. Therefore we propose adding the actualVehicleEquipments property from Vehicle to VehicleType in order to allow assigning equipment to a VehicleType.

Having VehicleType/actualVehicleEquipments containing EquipmentRef or Equipment also allows defining the equipment directly on the VehicleType indicating it is somewhere available on the vehicle. When using DeckPlan it can then additionally be referenced or "instantiated" by a particular EquipableSpace. Since a vehicle equipment is usually only used at one particular VehicleType and not throughout multiple, defining it on the VehicleType makes sense and also improves the portability of the VehicleType data.

Questions and remarks

  • Would DeckPlan elements be able to reference equipment defined in a VehicleType as assumed above?

  • What is the use case of VehicleTypeRef in ActualVehicleEquipmentGroup? Why can an equipment reference a VehicleType?

  • There is a small naming inconsistency (same name but different content):

    • Vehicle/actualVehicleEquipments contains EquipmentRef or Equipment
    • EquipableSpaceGroup/actualVehicleEquipments contains ActualVehicleEquipment

    To be more consistent actualVehicleEquipments from Vehicle should be named vehicleEquipments following the existing placeEquipments property, but I suppose it is too late for this change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions