Add animalsAllowed to NuisanceFacilityEnumeration#132
Merged
skinkie merged 1 commit intoApr 13, 2022
Merged
Conversation
Aurige
approved these changes
Jun 3, 2021
Aurige
added
the
needs documentation update
skinkie
added
needs-example
skinkie
approved these changes
Jun 3, 2021
skinkie
added
the
needs documentation update
ue71603
approved these changes
Apr 13, 2022
skinkie
approved these changes
Apr 13, 2022
erlendnils1
pushed a commit
to entur/NeTEx
that referenced
this pull request
Jun 29, 2023
trurlurl
added
document has been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #233
As documented in NeTEx part - 1 7.7.14.4.2 Accommodation Facilities
Further NuisanceFacilityEnumeration consolidation requested:
And "other" is missing in the XSD, instead implemented as "unknown"
In this case "other" makes more sense semantically (as not specified equals unknown), but if deprecating "unknown" this enumeration type is no longer backwards compatible.
Have therefore not added this enumeration to the XSD, would still recommend replacing "unknown" with "other".
If not, the UML and NuisanceFacilityType – AllowedValues must be updated to "unknown", or the type should contain both enumeration values.