TicketingFacilityEnumeration to ScopeOfTicketEnumeration#243
Conversation
There was a problem hiding this comment.
-
Not backwards compatible, obviously, but being a bug this fix is necessary. Do we need a deprecation/grace period?
-
I believe the fix on line 1289 should be reverted, because
<xsd:element name="TicketingFacility" type="TicketingFacilityEnumeration" default="unknown">
should remain of TicketingFacilityEnumeration, as this is the "Types of TICKETING available" (i.e. "Allowed values for TicketingFacility")
However, the ScopeOfTicketList should be of type ScopeOfTicketListOfEnumerations (not "TicketingFacilityListOfEnumerations")
I.e. change line line 1277 to:
<xsd:element name="ScopeOfTicketList" type="ScopeOfTicketListOfEnumerations">
For elaboration of practical implications, see also comments on issue #235
ue71603
dismissed
syversenkr’s stale review
Commit did the requested change., but somehow I can't accept the change. Probably because it is Stefan's PR
…cosystem#243) * TicketingFacilityEnumeration to ScopeOfTicketEnumeration Fix TransmodelEcosystem#235 Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
…cosystem#243) * TicketingFacilityEnumeration to ScopeOfTicketEnumeration Fix TransmodelEcosystem#235 Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
4 participants
Fix #235