Merge validityparameters#330
Closed
skinkie wants to merge 6 commits into
Closed
Conversation
….com/entur/NeTEx into entur-validityparameters_transportmode_cen
Contributor
Author
|
I guess I need to fight harder. |
Contributor
|
Modes of transport and vehicle modes are very close ... that looks weird to have both ... furthermore one is a list the other is a single value |
ue71603
reviewed
Apr 19, 2022
Contributor
ue71603
left a comment
ue71603
left a comment
There was a problem hiding this comment.
VehicleModes exists now in ModeValiditdyParametersGroup and OrganisationValidityParametersGroup that results in an ambiguous model ==> remove VehicleModes from OrganiationValidityParametersGroup.
I think we should drop the whole PR.
This was referenced Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #145