Skip to content

Fix IsDIrect => IsDirect#40

Closed
skinkie wants to merge 2 commits into
TransmodelEcosystem:masterfrom
skinkie:fix_isdirect
Closed

Fix IsDIrect => IsDirect#40
skinkie wants to merge 2 commits into
TransmodelEcosystem:masterfrom
skinkie:fix_isdirect

Conversation

@skinkie
Copy link
Copy Markdown
Contributor

@skinkie skinkie commented Jan 7, 2019

No description provided.

@skinkie skinkie added the enhancement non semantic enhacement: technical enhancement, etc. label Jan 7, 2019
@skinkie skinkie requested review from Aurige and seime January 7, 2019 06:56
<xsd:element name="IsDIrect" type="xsd:boolean" minOccurs="0">
<xsd:element name="IsDirect" type="xsd:boolean" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Wheter considered as direct fare.</xsd:documentation>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether

Copy link
Copy Markdown
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is logical, however still the same comment, it changes a tag name (backward compatibility issue), therefore we need to inform the group about it and be prepared to have a solution (substitution group ?) in case it is requested !

@skinkie skinkie closed this in 17c3b06 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement non semantic enhacement: technical enhancement, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants