Skip to content

fix(acp): harden hosted credential fallback (merged via #118) - #119

Closed
Travis-Gilbert wants to merge 2 commits into
mainfrom
cursor/fix-acp-hosted-cred-d6cb
Closed

fix(acp): harden hosted credential fallback (merged via #118)#119
Travis-Gilbert wants to merge 2 commits into
mainfrom
cursor/fix-acp-hosted-cred-d6cb

Conversation

@Travis-Gilbert

Copy link
Copy Markdown
Owner

Summary

Companion branch for the ACP hosted-credential follow-up that landed in #118.

  • Clears all auth credential env vars in the transport contract test
  • Adds vitest for @commonplace/theorem-acp and runs it in console CI

Status

Already merged to main via squash of #118 (615b6d9). This PR exists only to register the cursor/fix-acp-hosted-cred-d6cb working branch; it can be closed.

Open in Web Open in Cursor 

Travis-Gilbert and others added 2 commits July 25, 2026 18:50
Clear all auth credential env vars so the transport contract stays
deterministic, and wire theorem-acp vitest into console CI.

Co-authored-by: Travis Gilbert <Travis-Gilbert@users.noreply.github.com>
@ecc-tools

ecc-tools Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 31412396-eb99-4940-b094-d97b25b7a720

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-acp-hosted-cred-d6cb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Already landed on main via #118 (615b6d9). Closing this companion draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants