feat(console): land v2 proactivity live APIs on main (#79) - #80
Merged
Conversation
Co-authored-by: Travis Gilbert <Travis-Gilbert@users.noreply.github.com>
Keep the live harness hydrate path from #79 without requiring the prop when the editable ProactivityView path is active. Co-authored-by: Travis Gilbert <Travis-Gilbert@users.noreply.github.com>
Replace raw text-red-700 so gate:register stays clean. Co-authored-by: Travis Gilbert <Travis-Gilbert@users.noreply.github.com>
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (28)
📝 WalkthroughWalkthroughThe console adds a typed proactivity graph projection with GraphQL mutations, tenant-filtered SSE events, ACP-backed compilation review, deterministic React Flow rendering, firing-path highlights, and commit/discard controls. ChangesProactivity graph integration
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ProactivityGraphView
participant ConsoleAPI
participant GraphQLHarness
participant Changefeed
User->>ProactivityGraphView: Open console
ProactivityGraphView->>ConsoleAPI: GET proactivity graph
ConsoleAPI->>GraphQLHarness: Query projection
GraphQLHarness-->>ConsoleAPI: Graph
ConsoleAPI-->>ProactivityGraphView: Initial graph
ProactivityGraphView->>ConsoleAPI: Open SSE stream
ConsoleAPI->>Changefeed: Fetch tenant-filtered feed
Changefeed-->>ProactivityGraphView: Firing event
ProactivityGraphView->>ProactivityGraphView: Highlight firing path
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rehomes the unique work from open PR #79 onto
main(canonical CommonPlace console atapps/console/v2.theoremharness.com).#79 targeted the stacked feature branch
Travis-Gilbert/console-composer-densityand conflicted with main after #75/#76/#78. This PR:ProactivityGraphViewProactivityView(from feat(console): editable proactivity graph surface (SPEC-PROACTIVITY-GRAPH-SURFACE) #63/feat(console): typed node-model blocks and typography for proactivity #76) as the registeredproactivity.graphsurfaceinitialProactivityoptional onConsoleAppso the live hydrate path does not break the fixture-backed viewTest plan
pnpm testinapps/console(125 passing)gate:fence,gate:register,gate:motion,gate:iconsSupersedes the merge intent of #79 (wrong base). #74/#73 remain open but are largely superseded by already-merged #75/#76; this agent cannot retarget or close them (token lacks update permission).
Summary by CodeRabbit