feat: add size ceiling and per-train output opt-out to SaveTrainParam…#102
Merged
Conversation
…eters
Parameter capture was global and unbounded, so a fan-out of trains returning multi-MB payloads could OOM the host serializing them concurrently and bloat trax.metadata.
MaxParameterBytes caps every serialized parameter: it streams through a byte-counting writer and aborts as soon as the cap is crossed, storing a small {"_truncated": true} placeholder instead of materializing the whole payload. ExcludeOutput (string/Type/generic) and the ShouldSaveOutputs predicate skip output for known-large trains while keeping their inputs. A null cap leaves the previous behavior unchanged.
Theauxm
force-pushed
the
feat/bounded-train-parameters
branch
from
bc27fdc to
98d3735
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ng from coverage Add branch tests for ExcludeOutput(Type) with a null-FullName type and the null-name opt-out path. Mark the ByteCeilingStream adapter [ExcludeFromCodeCoverage]: its Stream-contract members are never hit on a write-only stream, and the ceiling behavior is already covered through the over-cap and unbounded-output tests.
|
This PR is included in version 1.42.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eters
Parameter capture was global and unbounded, so a fan-out of trains returning multi-MB payloads could OOM the host serializing them concurrently and bloat trax.metadata.
MaxParameterBytes caps every serialized parameter: it streams through a byte-counting writer and aborts as soon as the cap is crossed, storing a small {"_truncated": true} placeholder instead of materializing the whole payload. ExcludeOutput (string/Type/generic) and the ShouldSaveOutputs predicate skip output for known-large trains while keeping their inputs. A null cap leaves the previous behavior unchanged.