fix(core): generate release notes for new fixed monorepo packages#147
Merged
Conversation
Coverage Report for CI Build 28290430603Coverage increased (+0.08%) to 59.717%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates release/tag detection in core to correctly generate release notes (and bump behavior) when introducing new packages into a fixed-version monorepo after a prior fixed release tag already exists. It also refreshes the git-client dependency and refactors test helpers to expose both the working directory and a repository runner.
Changes:
- Upgrade
@conventional-changelog/git-clientto^3.0.1and adjust pnpm workspace/lockfiles accordingly. - Update first-release detection to use semver-tag-aware lookup (
getLastSemverTag) and propagatefirstReleaseinto fixed-mode monorepo bump option calculation. - Refactor test project mocks to return
{ cwd, run }context, and add a regression test covering “new package after fixed release tag” release-notes generation.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adjusts pnpm’s minimumReleaseAgeExclude configuration for the updated dependency version. |
| pnpm-lock.yaml | Locks updated dependency graph for @conventional-changelog/git-client@3.0.1 and related transitive updates. |
| packages/test/src/project.mock.ts | Refactors project fixture helpers to return a reusable { cwd, run } context and adds fixed-monorepo options. |
| packages/test/src/git.mock.ts | Broadens action return typing and introduces a named RepositoryRunner type for test repos. |
| packages/test/package.json | Bumps test package dependency on @conventional-changelog/git-client to ^3.0.1. |
| packages/pnpm/src/workspacesProject.spec.ts | Updates tests to use { cwd } from forkProject context. |
| packages/npm/src/workspacesProject.spec.ts | Updates tests to use { cwd } from forkProject context. |
| packages/github/src/index.spec.ts | Updates smoke test to use { cwd } returned by packageJsonProject. |
| packages/core/src/releaser.spec.ts | Updates smoke test to use { cwd } returned by packageJsonProject. |
| packages/core/src/project/project.ts | Switches first-release auto-detection to getLastSemverTag with prefix, improving correctness for semver-tagged repos. |
| packages/core/src/project/packageJsonMonorepo.spec.ts | Updates fixtures usage and adds a regression test for release notes on a newly added fixed-monorepo package. |
| packages/core/src/project/packageJson.spec.ts | Updates fixtures usage to use { cwd } context. |
| packages/core/src/project/monorepo.ts | Computes fixed-mode firstRelease once from semver tags and passes it into per-project bump option composition. |
| packages/core/package.json | Bumps core dependency on @conventional-changelog/git-client to ^3.0.1. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| simple-git-hooks: true | ||
| minimumReleaseAgeExclude: | ||
| - '@conventional-changelog/git-client@3.0.0' | ||
| - '@conventional-changelog/git-client@3.0.0 || 3.0.1' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.