feat(a2a-nats): agent + message-send + message-stream subject types - #321
Merged
Conversation
yordis
commented
Jun 18, 2026
yordis
commented
Member
- Three per-operation subject value objects (AgentCardSubject / MessageSendSubject / MessageStreamSubject) under {prefix}.agents.{agent_id}.*; each implements the typestate markers (Requestable + StreamAssignment) so call sites can't accidentally publish a unary request as fire-and-forget or look up a JetStream stream for a subject that has none.
- Lands these three together because they share the same subject leader and tests; the tasks/* and push/* operation subjects land in dedicated follow-ups so each per-operation PR's wire contract is reviewed on its own.
Three per-operation subject value objects (AgentCardSubject /
MessageSendSubject / MessageStreamSubject) under {prefix}.agents.{agent_id}.*.
Each implements Requestable + StreamAssignment so the call sites can't
accidentally publish a unary request as fire-and-forget or look up a
JetStream stream for a subject that has none. Tasks + push operation
subjects land in dedicated follow-up PRs.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview All three are marked Reviewed by Cursor Bugbot for commit ab84326. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThree new NATS subject structs ( ChangesAgent NATS Subject Types
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: ab84326 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
…isplay Each per-operation subject now has unit tests asserting the Display output and ToSubject round-trip so the coverage gate isn't blocked by brand-new files starting at 0%. Also align the message_stream doc comment on the plural .tasks. event-subject leader the rest of the codebase uses. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 18, 2026
…321) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.