feat(a2a-nats): add client push_get per-operation method - #343
Conversation
yordis
commented
Jun 19, 2026
- Per-op slice of the client handle: callers that registered a push config need the symmetric read path to inspect or refresh it, with the same typed TaskNotFound semantics as the rest of the push ops.
Callers that registered a push config via push_set need the symmetric read path to inspect or refresh the registration; routing it through the same handle keeps the typed TaskNotFound semantics consistent across push ops. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview The method issues a unary JSON-RPC Unit tests cover default agent subjects, gateway subject overlay, task-not-found, and transport failures. Reviewed by Cursor Bugbot for commit b30eb5d. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a Changespush_get operation on A2aClient
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Coverage SummaryDetailsDiff against mainResults for commit: b30eb5d Minimum allowed coverage is ♻️ This comment has been updated with latest results |