feat(a2a-nats): add server push_list handler - #355
Merged
Conversation
yordis
commented
Jun 19, 2026
yordis
commented
Member
- Per-op slice of the server dispatch: paginated discovery of a task's push registrations, so callers can reconcile what they registered against what the agent retained.
Paginated discovery of a task's push registrations is the symmetric read path that lets callers reconcile what they registered against what the agent retained. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview
Test Reviewed by Cursor Bugbot for commit e3e94f4. Bugbot is set up for automated code reviews on this repo. Configure here. |
WalkthroughAdds a Changespush_notification_list NATS handler
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: e3e94f4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rsworkspace/crates/a2a-nats/src/server/push_list.rs`:
- Around line 27-29: The deserialization error in the match arm for
serde_json::from_value on ListTaskPushNotificationConfigsRequest is being
converted to a string via format! when constructing A2aError::new, which
discards the typed error context. Instead of formatting the error e into a
string, modify the A2aError::new call to preserve the serde_json::Error as a
typed field or variant so that error context and source information is retained
for debugging rather than being flattened into a string representation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8c65ce13-c8ad-4801-9567-f7731cd1c148
📒 Files selected for processing (4)
rsworkspace/crates/a2a-nats/src/server/handler.rsrsworkspace/crates/a2a-nats/src/server/mod.rsrsworkspace/crates/a2a-nats/src/server/push_list.rsrsworkspace/crates/a2a-nats/src/server/test_support.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.