feat(semconv): migrate runtime telemetry onto generated constants - #413
Merged
Conversation
yordis
commented
Jun 26, 2026
yordis
commented
Member
- Single-sources metric, span, and attribute identifiers from the Weaver registry so runtime telemetry cannot drift from the declared semantic conventions.
- Adds span codegen so span names are emitted alongside attributes and metrics, closing the last gap that forced hand-written constants.
Keeps metric, span, and attribute identifiers single-sourced from the Weaver registry so call sites cannot drift from the declared semantic conventions. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview Call-site migration spans Enforcement: a new Reviewed by Cursor Bugbot for commit d7875ce. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reached
More reviews will be available in 15 minutes and 23 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (29)
WalkthroughThe PR adds generated Rust span bindings to ChangesSemantic convention generation and runtime use
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: d7875ce Minimum allowed coverage is ♻️ This comment has been updated with latest results |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
rsworkspace/crates/trogon-gateway/src/source/linear/server.rs (1)
262-266: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider importing attribute constants for consistency.
You import
LINEAR_WEBHOOKbut use fully-qualified paths (trogon_semconv::attribute::*) for the fivespan.record()calls. ImportingEVENT_TYPE,ACTION,WEBHOOK_ID,SUBJECT, andMESSAGING_MESSAGE_BODY_SIZEwould align with the span-name pattern and reduce line noise.-use trogon_semconv::span::LINEAR_WEBHOOK; +use trogon_semconv::{ + attribute::{ACTION, EVENT_TYPE, MESSAGING_MESSAGE_BODY_SIZE, SUBJECT, WEBHOOK_ID}, + span::LINEAR_WEBHOOK, +};Then lines 262–266 could use the unqualified constants directly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogon-gateway/src/source/linear/server.rs` around lines 262 - 266, The `record_webhook` span attribute calls currently use fully qualified `trogon_semconv::attribute::*` names while `LINEAR_WEBHOOK` is imported, creating inconsistent style. Update the imports in `server.rs` to bring `EVENT_TYPE`, `ACTION`, `WEBHOOK_ID`, `SUBJECT`, and `MESSAGING_MESSAGE_BODY_SIZE` into scope, then switch the corresponding `span.record()` calls to use the unqualified constants. Keep the existing `LINEAR_WEBHOOK` import pattern consistent with these span attribute references.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rsworkspace/crates/a2a-nats/src/server/push_get.rs`:
- Line 2: The #[instrument] span name in the push_get server code must use a
string literal, so the A2A_SERVER_PUSH_GET constant cannot be passed there.
Update the instrumented function in push_get.rs to use the literal span name
directly, and then remove the now-unused A2A_SERVER_PUSH_GET import from
trogon_semconv::span if nothing else references it.
---
Nitpick comments:
In `@rsworkspace/crates/trogon-gateway/src/source/linear/server.rs`:
- Around line 262-266: The `record_webhook` span attribute calls currently use
fully qualified `trogon_semconv::attribute::*` names while `LINEAR_WEBHOOK` is
imported, creating inconsistent style. Update the imports in `server.rs` to
bring `EVENT_TYPE`, `ACTION`, `WEBHOOK_ID`, `SUBJECT`, and
`MESSAGING_MESSAGE_BODY_SIZE` into scope, then switch the corresponding
`span.record()` calls to use the unqualified constants. Keep the existing
`LINEAR_WEBHOOK` import pattern consistent with these span attribute references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4b8e3bfa-fff6-4b79-bd0b-bcae81cb55c1
⛔ Files ignored due to path filters (5)
rsworkspace/Cargo.lockis excluded by!**/*.lockrsworkspace/crates/trogon-semconv/src/gen/attribute.rsis excluded by!**/gen/**rsworkspace/crates/trogon-semconv/src/gen/metric.rsis excluded by!**/gen/**rsworkspace/crates/trogon-semconv/src/gen/mod.rsis excluded by!**/gen/**rsworkspace/crates/trogon-semconv/src/gen/span.rsis excluded by!**/gen/**
📒 Files selected for processing (76)
otel/semconv/README.mdotel/semconv/registry/acp.yamlotel/semconv/registry/mcp.yamlotel/semconv/templates/registry/rust/mod.rs.j2otel/semconv/templates/registry/rust/span.rs.j2otel/semconv/templates/registry/rust/weaver.yamlrsworkspace/crates/a2a-nats/Cargo.tomlrsworkspace/crates/a2a-nats/src/server/agent_card.rsrsworkspace/crates/a2a-nats/src/server/message_send.rsrsworkspace/crates/a2a-nats/src/server/message_stream.rsrsworkspace/crates/a2a-nats/src/server/push_delete.rsrsworkspace/crates/a2a-nats/src/server/push_get.rsrsworkspace/crates/a2a-nats/src/server/push_list.rsrsworkspace/crates/a2a-nats/src/server/push_set.rsrsworkspace/crates/a2a-nats/src/server/tasks_cancel.rsrsworkspace/crates/a2a-nats/src/server/tasks_get.rsrsworkspace/crates/a2a-nats/src/server/tasks_list.rsrsworkspace/crates/a2a-nats/src/server/tasks_resubscribe.rsrsworkspace/crates/acp-nats/Cargo.tomlrsworkspace/crates/acp-nats/src/agent/authenticate.rsrsworkspace/crates/acp-nats/src/agent/cancel.rsrsworkspace/crates/acp-nats/src/agent/close_session.rsrsworkspace/crates/acp-nats/src/agent/ext_method.rsrsworkspace/crates/acp-nats/src/agent/ext_notification.rsrsworkspace/crates/acp-nats/src/agent/fork_session.rsrsworkspace/crates/acp-nats/src/agent/initialize.rsrsworkspace/crates/acp-nats/src/agent/list_sessions.rsrsworkspace/crates/acp-nats/src/agent/load_session.rsrsworkspace/crates/acp-nats/src/agent/logout.rsrsworkspace/crates/acp-nats/src/agent/new_session.rsrsworkspace/crates/acp-nats/src/agent/prompt.rsrsworkspace/crates/acp-nats/src/agent/resume_session.rsrsworkspace/crates/acp-nats/src/agent/set_session_config_option.rsrsworkspace/crates/acp-nats/src/agent/set_session_mode.rsrsworkspace/crates/acp-nats/src/agent/set_session_model.rsrsworkspace/crates/acp-nats/src/client/ext.rsrsworkspace/crates/acp-nats/src/client/ext_session_prompt_response.rsrsworkspace/crates/acp-nats/src/client/fs_read_text_file.rsrsworkspace/crates/acp-nats/src/client/fs_write_text_file.rsrsworkspace/crates/acp-nats/src/client/mod.rsrsworkspace/crates/acp-nats/src/client/request_permission.rsrsworkspace/crates/acp-nats/src/client/session_update.rsrsworkspace/crates/acp-nats/src/client/terminal_create.rsrsworkspace/crates/acp-nats/src/client/terminal_kill.rsrsworkspace/crates/acp-nats/src/client/terminal_output.rsrsworkspace/crates/acp-nats/src/client/terminal_release.rsrsworkspace/crates/acp-nats/src/client/terminal_wait_for_exit.rsrsworkspace/crates/acp-nats/src/telemetry/metrics.rsrsworkspace/crates/mcp-nats/Cargo.tomlrsworkspace/crates/mcp-nats/src/telemetry/transport.rsrsworkspace/crates/mcp-nats/src/transport.rsrsworkspace/crates/trogon-gateway/Cargo.tomlrsworkspace/crates/trogon-gateway/src/source/github/server.rsrsworkspace/crates/trogon-gateway/src/source/gitlab/server.rsrsworkspace/crates/trogon-gateway/src/source/incidentio/server.rsrsworkspace/crates/trogon-gateway/src/source/linear/server.rsrsworkspace/crates/trogon-gateway/src/source/microsoft_graph/server.rsrsworkspace/crates/trogon-gateway/src/source/notion/server.rsrsworkspace/crates/trogon-gateway/src/source/sentry/server.rsrsworkspace/crates/trogon-gateway/src/source/slack/server.rsrsworkspace/crates/trogon-gateway/src/source/telegram/server.rsrsworkspace/crates/trogon-gateway/src/source/twitter/server.rsrsworkspace/crates/trogon-nats/Cargo.tomlrsworkspace/crates/trogon-nats/src/connect.rsrsworkspace/crates/trogon-nats/src/messaging.rsrsworkspace/crates/trogon-nats/src/telemetry/messaging.rsrsworkspace/crates/trogon-nats/src/telemetry/messaging/tests.rsrsworkspace/crates/trogon-scheduler/Cargo.tomlrsworkspace/crates/trogon-scheduler/src/processor/execution/worker/processor.rsrsworkspace/crates/trogon-scheduler/src/telemetry/metrics.rsrsworkspace/crates/trogon-semconv/src/lib.rsrsworkspace/crates/trogon-std/Cargo.tomlrsworkspace/crates/trogon-std/src/telemetry/http.rsrsworkspace/crates/trogon-std/src/telemetry/http/tests.rsrsworkspace/crates/trogon-telemetry/Cargo.tomlrsworkspace/crates/trogon-telemetry/src/constants.rs
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added
the
rust:coverage-baseline-reset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.