This repository was archived by the owner on Nov 28, 2022. It is now read-only.
🦄 Improved theme validation messages#812
Merged
kirrg001 merged 1 commit intoTryGhost:masterfrom Aug 2, 2017
Merged
Conversation
closes TryGhost/Ghost#8530 - Changed the wording for activation and uploading a theme to separate between error and warnings in the title and the body text for the modal - Changed the wording of "Activated successful with warnings/errors" to "Activation successful with (warnings || errors)"
kirrg001
approved these changes
Aug 2, 2017
Contributor
kirrg001
left a comment
kirrg001
left a comment
There was a problem hiding this comment.
Tested theme with warnings and theme with errors, the wording has changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8530