Fix horizontal scrolling caused by scaling on the subscribe CTA h2#765
Merged
Conversation
2d177a8 to
256b321
Compare
Member
|
Agree with approach, but if we're going to manually specify font sizes then lets just specify absolute values in rem rather than calc * 1.15 - makes it a bit more readable |
Member
Author
|
Absolute valued was my first approach, but I thought this would make find/replace easier. Agreed though, will change. |
256b321 to
81e4a3f
Compare
Member
|
@PaulAdamDavis Media query style now specifies EM rather than REM, is that intentional or typo? |
81e4a3f to
65b085e
Compare
Member
Author
|
@JohnONolan Typo, thanks for spotting! Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transform: scale(1.15);on the subscribe CTAh2caused horizontal scrolling on smaller screens, as illustrated by the red outlines in the before screenshot.This PR removes that
transformin favour if increasing the font-size by 15%, matching the same visual size that the transform produced.Before:
After: