fixes issue with compiled JavaScript not being copied to statix/dist …#10
Merged
Conversation
…folder and loaded with Browsersync
…bal `statix` folder changes instead of `statix/src`
ashleynolan
reviewed
May 11, 2017
| const runSequence = require('run-sequence'); | ||
|
|
||
| gulp.task('watch', ['compile'], () => { | ||
| gulp.watch(['**/*.scss'], { cwd: config.css.scssDir }, ['css']) |
Contributor
There was a problem hiding this comment.
Should this also include the copy task for the CSS? Or is it that the CSS is already being copied as part of the CSS task?
Author
There was a problem hiding this comment.
this here takes care of CSS copy part - https://github.com/TryKickoff/statix/blob/next/.kickoff/tasks/css.js#L71
so, yes CSS copy is already done in css task
Contributor
There was a problem hiding this comment.
Ok – just wanted to check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #9 where compiled JavaScript is not being copied to statix/dist folder and loaded with Browsersync