Skip to content

Do not download an audio file when not exist#35

Merged
Tusko merged 1 commit intoTusko:masterfrom
nikukyugamer:fix/error_in_video_without_audio
Mar 7, 2022
Merged

Do not download an audio file when not exist#35
Tusko merged 1 commit intoTusko:masterfrom
nikukyugamer:fix/error_in_video_without_audio

Conversation

@nikukyugamer
Copy link
Copy Markdown
Contributor

If an audio file doesn't exist in the target file, master.json's audio property's value is null.

For example: https://wonderpla.net/

{
  "clip_id": "ddd0bdb4-a498-4b6e-bb02-3900fbefe90d",
  "base_url": "../",
  "video": [...],
  "audio": null
}

So json.audio.sort occurs an Uncaught TypeError: Cannot read properties of null error.

I fixed it.

@Tusko Tusko merged commit 62d6d07 into Tusko:master Mar 7, 2022
@Tusko
Copy link
Copy Markdown
Owner

Tusko commented Mar 7, 2022

Thank you @nikukyugamer

@nikukyugamer nikukyugamer deleted the fix/error_in_video_without_audio branch March 7, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants