This repository was archived by the owner on May 22, 2023. It is now read-only.
Code Exchange upgrade#31
Merged
Merged
Conversation
added 2 commits
April 21, 2020 15:57
po5i
force-pushed
the
code-exchange-upgrade
branch
from
db43af1 to
157a079
Compare
po5i
force-pushed
the
code-exchange-upgrade
branch
from
3d9ead2 to
3db1ce8
Compare
added 2 commits
May 29, 2020 11:01
fefi95
reviewed
Jun 17, 2020
Comment on lines
+67
to
+73
| // wrap the phone number or client name in the appropriate TwiML verb | ||
| // by checking if the number given has only digits and format symbols | ||
| if(to.matches("^[\\d\\+\\-\\(\\) ]+$")) { | ||
| dialBuilder = dialBuilder.number(new Number.Builder(to).build()); | ||
| } else { | ||
| dialBuilder = dialBuilder.client(new Client.Builder(to).build()); | ||
| } |
There was a problem hiding this comment.
Maybe this can be in another function (private) just to make it clearer. Do you think it's worth it?
Contributor
Author
There was a problem hiding this comment.
Nice suggestion. Want to take another look?
| post("/voice", "application/x-www-form-urlencoded", (request, response) -> { | ||
| VoiceResponse voiceTwimlResponse; | ||
| String to = request.queryParams("To"); | ||
| if (to != null) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #30