This repository was archived by the owner on May 22, 2023. It is now read-only.
Code Exchange Upgrade#7
Merged
Merged
Conversation
po5i
force-pushed
the
code-exchange-upgrade
branch
from
32764d8 to
3240c16
Compare
po5i
force-pushed
the
code-exchange-upgrade
branch
from
3240c16 to
8f5646e
Compare
po5i
force-pushed
the
code-exchange-upgrade
branch
from
7799800 to
5a1ba45
Compare
| @@ -103,6 +99,9 @@ We'd recommend Google Chrome or Mozilla Firefox instead. | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
This app doesnt seem to work for me. I constantly get Twilio.Device Error: Invalid Access Token issuer/subject
Contributor
Author
There was a problem hiding this comment.
Are you testing locally with the code-exchange-upgrade branch?
Are TWILIO_ACCOUNT_SID, API_KEY, and API_SECRET values correct in your .env file?
There was a problem hiding this comment.
not sure what changed, but this started working for me again. are we correctly setting the environment variables whenever the app is run? or do we expect the user to manually source .env after making changes to the file?
Contributor
Author
There was a problem hiding this comment.
It's not needed to source .env. This change was introduced in this PR.
bharatmurali
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6