This repository was archived by the owner on Apr 11, 2021. It is now read-only.
Move upgradeFiles function to a new file#32
Merged
mzfr merged 1 commit intoTypeError:masterfrom Jun 8, 2019
mzfr:refactor
Merged
Move upgradeFiles function to a new file#32mzfr merged 1 commit intoTypeError:masterfrom mzfr:refactor
mzfr merged 1 commit intoTypeError:masterfrom
mzfr:refactor
Conversation
cak
approved these changes
Feb 18, 2019
Member
|
Doh! I merged #34 and will have to work on the conflicts. |
Contributor
Author
|
@cak I updated the PR so I think you can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main file contains a lot of so it should be refactored somehow to make the code clean. So I moved the
upgradeFiles()function into a new file since all it did was cloning and printing general info.Please let me know if anything other change is required.