🎨 Palette: Add proper label association to In-Game Name input#575
🎨 Palette: Add proper label association to In-Game Name input#575google-labs-jules[bot] wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added proper label association for the "In-Game Name" text input in
activity/src/components/RoleEditor.tsx. Replaced the generic<div>with a semantic<label>tag and linked it to the input field using a unique ID generated via React'suseId()hook.🎯 Why:
Previously, the "In-Game Name" label was just a text string inside a
<div>, which means screen readers could not programmatically associate it with the text input field. Linking them improves accessibility compliance and allows users to click the label to focus the input.📸 Before/After:
No visual changes.
♿ Accessibility:
div.role-editor-labelto a semantic<label>tag.idto the text input and anhtmlForattribute to the label, linking the two.PR created automatically by Jules for task 15328447738242946101 started by @TytaniumDev