Conversation
Member
rernst
commented
Jul 31, 2023
rernst
commented
- Support for nextflow v23.04.2
- Changes are backward compatible, tested with (20.04.1.5335)
…xtflowModules into feature/upgrade_nextflow
lvanoijen
reviewed
Aug 8, 2023
lvanoijen
reviewed
Aug 8, 2023
lvanoijen
reviewed
Aug 8, 2023
lvanoijen
reviewed
Aug 8, 2023
lvanoijen
reviewed
Aug 8, 2023
lvanoijen
reviewed
Aug 8, 2023
lvanoijen
requested changes
Aug 8, 2023
lvanoijen
left a comment
lvanoijen
left a comment
There was a problem hiding this comment.
Almost ok. There are some closing brackets missing. And looking at the files that aren't changed there is 1 val() change missed in the input of file GATK/4.1.3.0/SplitIntervals.nf.
Member
Author
Thanks, fixed the missing brackets and val() change. Also merged develop to fix merge conflict. |
lvanoijen
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.