Add cdd_remove_negative#16
Merged
mikucionisaau merged 3 commits intoJun 19, 2022
Merged
Conversation
Member
|
You have added a new function. Could you please add a unit test for it? |
Member
|
Could you please do a rebase on your branch so that the tests would work on Windows? Please be carefull: stop if any of the intermediate commands fail |
magoorden
force-pushed
the
add-cdd_remove_negative
branch
from
June 17, 2022 09:42
154dda7 to
d09bf89
Compare
Contributor
Author
|
Done, and I see that now all checks pass, including the Windows one 😄. |
magoorden
force-pushed
the
add-cdd_remove_negative
branch
from
June 17, 2022 12:19
0275a07 to
7f56d81
Compare
mikucionisaau
approved these changes
Jun 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a CDD is used in the context of timed-automata, clock values cannot be negative. Converting a CDD that allows negative clock values to a DBM results in an invalid DBM. The method
cdd_remove_negativeremoves all negative clock values from a CDD.