Skip to content

Add cdd_remove_negative#16

Merged
mikucionisaau merged 3 commits into
UPPAALModelChecker:mainfrom
Ecdar:add-cdd_remove_negative
Jun 19, 2022
Merged

Add cdd_remove_negative#16
mikucionisaau merged 3 commits into
UPPAALModelChecker:mainfrom
Ecdar:add-cdd_remove_negative

Conversation

@magoorden

Copy link
Copy Markdown
Contributor

When a CDD is used in the context of timed-automata, clock values cannot be negative. Converting a CDD that allows negative clock values to a DBM results in an invalid DBM. The method cdd_remove_negative removes all negative clock values from a CDD.

@mikucionisaau

Copy link
Copy Markdown
Member

You have added a new function. Could you please add a unit test for it?
It should model your described case, fail without your patch and pass with your patch.

@mikucionisaau

Copy link
Copy Markdown
Member

Could you please do a rebase on your branch so that the tests would work on Windows?
like:

git checkout main
git pull
git checkout add-cdd_remove_negative
git rebase main
git push --force

Please be carefull: stop if any of the intermediate commands fail

@magoorden
magoorden force-pushed the add-cdd_remove_negative branch from 154dda7 to d09bf89 Compare June 17, 2022 09:42
@magoorden

Copy link
Copy Markdown
Contributor Author

Done, and I see that now all checks pass, including the Windows one 😄.

@magoorden
magoorden force-pushed the add-cdd_remove_negative branch from 0275a07 to 7f56d81 Compare June 17, 2022 12:19
Comment thread include/cdd/cdd.h
Comment thread include/cdd/cdd.h
Comment thread test/test_cdd.cpp Outdated
Comment thread test/test_cdd.cpp
Comment thread test/test_cdd.cpp
@mikucionisaau
mikucionisaau merged commit 40728a6 into UPPAALModelChecker:main Jun 19, 2022
@magoorden
magoorden deleted the add-cdd_remove_negative branch July 1, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants