Skip to content

Delete unmaintained wrappers#19

Merged
RasmusRendal merged 1 commit into
UPPAALModelChecker:mainfrom
RasmusRendal:deletewrappers
Jun 14, 2022
Merged

Delete unmaintained wrappers#19
RasmusRendal merged 1 commit into
UPPAALModelChecker:mainfrom
RasmusRendal:deletewrappers

Conversation

@RasmusRendal

Copy link
Copy Markdown
Contributor

These don't seem to have worked for years, so there is not much reason to keep them in main.

@yrke

yrke commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

If it does not work we can remove, we also have copy in the historic repo

@mikucionisaau

Copy link
Copy Markdown
Member

The wrappers are used in teaching to interact with DBMs via rubby scripts.
At least it used to be part of verification course together with BDDs.
I think we need to rewrite the Makefiles into CMakeLists.txt instead of killing them.
Swix is hard to get right as one has to accomodate multiple language bindings, I don't want to reengineer this.

@mikucionisaau
mikucionisaau marked this pull request as draft June 14, 2022 07:34
@mikucionisaau

Copy link
Copy Markdown
Member

I just checked it: it has been broken in 2017-18 and marinated in uppaal repo, because nobody cared to run the tests and it has not been published publically (the outside users used snapshots).
Basically this needs to be fixed (seems like most of the issues are trivial artefacts of find-and-replace spree) and not killed.

@mikucionisaau

Copy link
Copy Markdown
Member

It seems that ruby/swix bindings/wrapper used to be distributed as a separate package on Alexandre's webpage (@yrke do you have a snapshot perhaps?).
Also the wrapper build scripts depend on the UDBM being already installed as is consults with udbm-config utility, which should be replaced with find_udbm.cmake scripts... there are also some strange ruby script which patch Makefile.
Overall, I think it would be best to move the wrapper files into separate project as it used to be published.

@mikucionisaau
mikucionisaau marked this pull request as ready for review June 14, 2022 08:33
These don't seem to have worked for years, so there is not much reason
to keep them in main
@RasmusRendal
RasmusRendal merged commit 9d9e1a3 into UPPAALModelChecker:main Jun 14, 2022
@RasmusRendal
RasmusRendal deleted the deletewrappers branch June 14, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants