Draft generate latlon box#55
Closed
hongyuchen1030 wants to merge 37 commits into
Closed
Conversation
hongyuchen1030
commented
Jun 15, 2022
hongyuchen1030
commented
Contributor
- Finish the skeleton code of generating latlon box
- Add some helper functions in helper.py for latlonbox operation
…DRAFT_Generate_latlon_box
rajeeja
reviewed
Jun 16, 2022
… DRAFT_Generate_latlon_box � Conflicts: � .gitignore � test/test_grid.py � uxarray/grid.py � uxarray/helpers.py
Contributor
|
Please resolve conflicts (merge main to this branch), I just approved the test runs for this branch. |
… independent functions
Member
|
Thanks very much for this! I'd like to express an important thing before too long: This is much bigger than a manageable, reviewable PR. It includes more than one logically separate tasks (e.g. validate, Edge class, and lat-lon box calculation itself are tasks that should be implemented and reviewed in different PRs). We should split this into as many PRs as needed and get them reviewed separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.