Skip to content

fix(storybook): investigate and fix Node Property Trigger story render error#836

Draft
1980computer wants to merge 1 commit into
mainfrom
fix/node-property-trigger-story
Draft

fix(storybook): investigate and fix Node Property Trigger story render error#836
1980computer wants to merge 1 commit into
mainfrom
fix/node-property-trigger-story

Conversation

@1980computer

Copy link
Copy Markdown
Collaborator

Summary

Investigation notes

  • Global preview.tsx decorator only uses MUI ThemeProvider for parameters.material === true stories, so MUI/Emotion is not in the render path for this story
  • The add-expression-editor branch documented that Vite 8 (rolldown) caused white screens for MUI/Emotion stories and downgraded to Vite 7 as a fix. May be related.
  • Most likely suspects: Vite 8 module initialization ordering, or a Radix UI / shadcn component resolving differently under Rolldown

To reproduce

Navigate to Apollo React/Canvas > Components > Panels > Node Property Trigger > Default.

Next steps

  1. Run pnpm storybook locally and open the story in a real browser to get the full non-minified error + component stack
  2. Check if the error appears in dev mode as well as the production build
  3. Determine if adding entries to optimizeDeps.include in viteFinal resolves a pre-bundling issue

🤖 Generated with Claude Code

…ory error

React error #130 ("Element type is invalid: got undefined") reproduces on
the deployed Storybook for the Node Property Trigger Default story. Likely
a Vite 8 (rolldown) pre-bundling or lazy-init ordering issue. Tracking
comment added in viteFinal optimizeDeps as a starting point.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 18, 2026 18:22
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jun 18, 2026, 11:28:06 AM
apollo-docs 🟢 Ready Preview, Logs Jun 18, 2026, 11:28:06 AM
apollo-landing 🟢 Ready Preview, Logs Jun 18, 2026, 11:28:06 AM
apollo-vertex 🟢 Ready Preview, Logs Jun 18, 2026, 11:28:06 AM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1942 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1712
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to address a runtime-only Storybook render failure (React error #130: “Element type is invalid: got undefined”) affecting the Node Property Trigger story in apollo-react.

Changes:

  • Adds inline TODO/investigation notes in Storybook’s Vite optimizeDeps configuration block, referencing the failing story and suspected causes.

Comment on lines +191 to +193
// TODO: investigate React error #130 on NodePropertyTrigger story under Vite 8 (rolldown).
// Suspect: Rolldown lazy-init ordering or Radix UI pre-bundling mismatch.
// See: https://apollo-design.vercel.app/?path=/story/apollo-react-canvas-components-panels-node-property-trigger--default
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 35.0% 7.26 MB 27.53 MB ±0
@uipath/apollo-wind 38.6% 324.4 KB 2.23 MB −7 B
@uipath/ap-chat 85.8% 43.36 MB 55.68 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:storybook size:XS 0-9 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants