chore(deps): bump StackExchange.Redis from 2.10.1 to 2.13.17 - #83
Merged
Conversation
First step of the staged StackExchange.Redis upgrade toward 3.0. 2.13.17 is the latest 2.x and shares 3.0's public API, so it de-risks the major bump. No public API or runtime behavior change. The only breakage was a test fixture: SE.Redis 2.13.17 grew the internal StreamInfo constructor from 7 to 16 parameters, and RedisStreamHealthMaintainerTests fabricates StreamInfo via reflection with a hardcoded positional arg list. The old 7-arg call no longer bound, the fixture threw, and the maintainer's try/catch swallowed it — surfacing as "received no matching calls" on the downstream mocks. Production is unaffected (it gets real StreamInfo objects from SE.Redis deserialization, never this reflection). GenerateStreamInfo now fills by the ctor's actual parameter list and sets only the fields the maintainer reads, so it survives this bump and the upcoming 3.0 one. Verified: full suite green on net8.0 and net10.0 (1174/1174 each), including the live-Redis reflection guards from #82. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
requested review from
alinahornet,
cosminvlad,
litheon,
lucianaparaschivei and
razvalex
as code owners
July 16, 2026 19:35
razvalex
approved these changes
Jul 16, 2026
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step of the staged StackExchange.Redis upgrade toward
3.0.2.13.17is the latest2.xand shares3.0's public API (3.0.0 is a mirror of 2.13.17 with a rewritten internal IO core), so landing it first de-risks the major bump. No public API or runtime behavior change.Changes
StackExchange.Redis2.10.1→2.13.17inDirectory.Packages.props.RedisStreamHealthMaintainerTestsfixture: SE.Redis 2.13.17 grew the internalStreamInfoconstructor from 7 → 16 parameters. The test fabricatesStreamInfovia reflection with a hardcoded positional arg list, so the old 7-arg call no longer bound — the fixture threw, the maintainer'stry/catchswallowed it, and it surfaced asreceived no matching callson the downstreamIDatabasemocks. Production is unaffected (it gets realStreamInfoobjects from SE.Redis deserialization, never this reflection).GenerateStreamInfonow fills by the ctor's actual parameter list and sets only the fields the maintainer reads, so it survives this bump and the upcoming 3.0 one.[Unreleased].Test plan
dotnet test)Full suite green on net8.0 and net10.0 — 1174/1174 each — run with
RUN_REDIS_INTEGRATION_TESTS=1against a live Redis, including the reflection guards added in #82 (GetMasterPhysicalConnectionMetricsand the profilingGetStatement). Confirmed via a controlled revert that the fixture failure was caused by the bump and is fully resolved by the fixture fix.Linked issues
Fixes #
Contributor declaration
git commit -s).🤖 Generated with Claude Code