chore(deps): bump StackExchange.Redis from 2.13.17 to 3.0.17 - #86
Merged
Conversation
cosmin-staicu
requested review from
alinahornet,
cosminvlad,
litheon,
lucianaparaschivei and
razvalex
as code owners
July 16, 2026 20:43
5 tasks
Final step of the staged StackExchange.Redis upgrade. 3.0 is an internal IO-core rewrite that mirrors 2.13.17's public API, so there is no public API change. Stacked on the Logging.Abstractions bump (that package is a hard transitive prerequisite for 3.0). 3.0 removed SocketManager (its new IO core no longer uses one), so ConfigurationOptions.SocketManager is obsolete. Dropped the now-dead assignment in RedisConfigurationOptionsProvider and marked the backing option RedisConnectionOptions.ThreadPoolSocketManager [Obsolete] (no-op, non-breaking signature) so consumers get a signal rather than a silent no-op. The two silent-failing reflection paths were the upgrade's main risk. Verified against live Redis on both TFMs via the guards added in #82: hang-detection metrics (GetMasterPhysicalConnectionMetrics) still resolve real values, and the profiling GetStatement still carries the command key. Benchmarks' admin FLUSHALL is unaffected (the runner already sets allowAdmin=true). The Azure Entra/RESP3 path is covered by build + configurator unit tests only (no live Azure endpoint); its runtime behavior is unverified in this PR. Full suite green on net8.0 and net10.0 (1174/1174 each) with RUN_REDIS_INTEGRATION_TESTS=1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
force-pushed
the
chore/stackexchange-redis-3
branch
from
July 17, 2026 09:26
0145220 to
d103e81
Compare
|
alinahornet
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final step of the staged
StackExchange.Redisupgrade:2.13.17→3.0.17. 3.0 is an internal IO-core rewrite that mirrors 2.13.17's public API, so there is no public API change.Changes
Directory.Packages.props:StackExchange.Redis2.13.17→3.0.17.SocketManager(its new IO core no longer uses one), soConfigurationOptions.SocketManageris[Obsolete]. Dropped the now-dead assignment inRedisConfigurationOptionsProvider, and marked the backing optionRedisConnectionOptions.ThreadPoolSocketManager[Obsolete]— a no-op now, non-breaking (signature unchanged), so consumers get a compile-time signal instead of a silent no-op.[Unreleased].Risk & verification
The upgrade's main risk is the two silent-failing reflection paths into SE.Redis internals (they degrade with no error, so a green unit build proves nothing) — 3.0's IO-core rewrite touches exactly those internals. Both are covered by the live guards added in #82 and re-verified here against a real Redis on both TFMs:
RedisConnector.GetMasterPhysicalConnectionMetrics(hang detection) — still resolves real values.ProfiledCommandExtensions.GetStatement(telemetry) — still carries the command key.Other 3.0 changes checked: benchmarks' admin
FLUSHALLis unaffected (the Aspire runner already setsallowAdmin=true);Executeadmin-gating doesn't hit production paths (SCANis non-admin).Not verified: the Azure Entra / RESP3 runtime path — no live Azure endpoint. It is covered by build + the existing configurator unit tests only.
Test plan
dotnet test)Full suite green on net8.0 and net10.0 — 1174/1174 each — run with
RUN_REDIS_INTEGRATION_TESTS=1against a live Redis, including the #82 reflection guards (0 skipped).Linked issues
Fixes #
Contributor declaration
git commit -s).🤖 Generated with Claude Code