Question about the #7665 bug

[phazei]

I found this solution to the issue on stackoverflow:
http://stackoverflow.com/a/16540688/65985

Would a simple possible fix simply to change it from:

    if ( startXPos !== event.pageX || startYPos !== event.pageY ) {
        clickDragged = true;
    }

to

    if (       ( startXPos > event.pageX + 4 || startXPos < event.pageX - 4 )
            || ( startYPos > event.pageY + 4 || startYPos < event.pageY - 4 ) ) {
        clickDragged = true;
    }

[UltCombo]

Thank you for the useful code and link, however we have two points to consider here.

First off, the reason why the jQuery UI's Button widget checks mouse clicks coordinates. As I've explained here, the #6970 bug fix introduced this code to completely prevent users from drag-clicking, instead of actually fixing the widget to work with drag-clicks. IMO this was a bad decision as it harms usability (mostly touch and high DPI input devices).

My fix for #5518 did take care of inconsistent double and drag-clicks, making the coordinates checking code obsolete.

Then, I've tried to push the PR 945 to remove all that obsolete code, but it has been stagnated ever since.

As for the second point to consider, do you actually have to restrict how many pixels the user can drag the mouse/pointer device while clicking? I'd rather leave it to the default browser mechanic which the user is used to. That is, simply removing the unnecessary coordinate checks would be enough IMHO.

I'll note that I haven't kept up with jQuery UI development lately, but I believe most of this still applies. I may review my PR code and update it sometime, but it is not on my priorities at the moment - as long as you don't have to support IE<9, having customized checkbox/radio buttons is pretty easy with CSS :checked and adjacent sibling selectors.

[UltCombo]

Closing this as per jquery/jquery-ui#1120