Skip to content

Enable https on proxys backend connection - #837

Merged
sjulti merged 6 commits into
masterfrom
enable-https-on-proxys-backend-connection
Sep 26, 2025
Merged

Enable https on proxys backend connection#837
sjulti merged 6 commits into
masterfrom
enable-https-on-proxys-backend-connection

Conversation

@ghost

@ghost ghost commented Sep 24, 2025

Copy link
Copy Markdown

No description provided.

@ghost
ghost marked this pull request as ready for review September 25, 2025 14:20

namespace uh::cluster::proxy {

forward_stream::forward_stream(boost::asio::ip::tcp::socket& s,

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved them to the header since forward_stream is now template class.

Comment thread src/proxy/handler.cpp

namespace uh::cluster::proxy {

handler::handler(

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handler is not a template class, but it's member function is now template function

Comment thread src/proxy/handler.h
public:
using variant_stream =
std::variant<boost::asio::ip::tcp::socket,
boost::beast::ssl_stream<beast::tcp_stream>>;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the stream type we use

Comment thread src/proxy/handler.h Outdated
[this, &s](auto& ds) -> coro<void> {
co_await _handle(std::move(s), ds);
},
*downstream);

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where we instantiate and call _handle function accordingly

@sjulti
sjulti merged commit ff7bd98 into master Sep 26, 2025
11 checks passed
@sjulti
sjulti deleted the enable-https-on-proxys-backend-connection branch September 26, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant