quality-debt: inc/ui/class-login-form-element.php — PR #380 review feedback (medium)

[superdav42]

Unactioned Review Feedback

Source PR: #380
File: inc/ui/class-login-form-element.php
Reviewers: coderabbit
Findings: 1
Max severity: medium

---

MEDIUM: coderabbit (coderabbitai[bot])

File: inc/ui/class-login-form-element.php:835
⚠️ Potential issue | 🟡 Minor

Fix PHPCS block-comment spacing to keep quality checks green.

Line 828 triggers the reported check failure (“Empty line required before block comment”). Add a blank line before the block comment.

Proposed fix

 			$fields['lost-password'] = [
 				'type'            => 'html',
+
 				/*
 				 * Use wp_lostpassword_url() so the lostpassword_url filter
 				 * keeps users on their subsite domain instead of redirecting

🧰 Tools

🪛 GitHub Check: Code Quality Checks

[failure] 828-828:
Empty line required before block comment

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@inc/ui/class-login-form-element.php` around lines 828 - 835, The PHPCS
failure is caused by missing blank line before the block comment above the
'content' array entry in class-login-form-element.php; open the code around the
'content' => sprintf(... wp_lostpassword_url() ...) line and insert a single
empty line immediately before the /* block comment so there is a blank line
separating the previous code and the comment, then keep the comment and the
'content' assignment unchanged to satisfy the “Empty line required before block
comment” rule.

✅ Addressed in commit 85bce43

View comment

---

Auto-generated by quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.

[superdav42]

Already Fixed

This issue is already resolved. The PHPCS "Empty line required before block comment" violation was addressed in PR #380 (commit 706d963), which was merged into main on 2026-03-24.

What was done:

• The block comment explaining wp_lostpassword_url() was moved outside the array definition, placing it before $fields['lost-password'] = [ with a blank line preceding it
• This satisfies the PHPCS rule requiring an empty line before block comments

Verification:

• inc/ui/class-login-form-element.php lines 826–832 in current main show the comment correctly placed with a blank line before it
• No further action required