fix: SC2015 A&&B||C anti-pattern in bin/deploy.sh

[superdav42]

Quality Debt: ShellCheck SC2015

Source: Daily quality sweep 2026-03-25
File: bin/deploy.sh
Severity: Error (SC2015)

Finding

Note that A && B || C is not if-then-else. C may run when A is true. [SC2015]

The A && B || C pattern is not equivalent to if A; then B; else C; fi. If B exits non-zero, C will run unexpectedly. This can cause silent failures in deploy scripts.

Fix

Replace A && B || C patterns with explicit if/then/else blocks:

# Before (buggy)
some_command && success_action || failure_action

# After (correct)
if some_command; then
  success_action
else
  failure_action
fi

Acceptance Criteria

• All SC2015 violations in bin/deploy.sh replaced with explicit if/then/else
• shellcheck bin/deploy.sh reports zero SC2015 violations
• Deploy script behaviour unchanged (test with dry-run if available)

[superdav42]

This issue is already resolved. PR #440 (merged 2026-03-25) fixed all SC2015 violations in bin/deploy.sh — the A && B || C anti-pattern was replaced with { cmd || true; } as part of a broader ShellCheck cleanup across all bin/ scripts.

shellcheck bin/deploy.sh now exits 0 with zero violations.

Closing as resolved by #440.