REST API returns null for all meta-stored fields on Site and 6 other models

[vuckro]

Bug Description

The REST API returns null for all meta-stored properties across 7 models. This makes the API unusable for retrieving critical data like customer_id, membership_id, line_items, etc.

Root Cause

Base_Model::to_array() (line 840) uses get_object_vars($this) to serialize models. However, several models use lazy-loaded properties that are fetched from metadata tables only when their getter is called (e.g., get_customer_id() calls $this->get_meta('wu_customer_id')).

Since to_array() never calls these getters, the properties remain null in the serialized JSON response.

Affected Models and Fields

Model	Null Fields in API Response
Site	customer_id, membership_id, featured_image_id, categories + id returns 0 instead of blog_id
Product	featured_image_id, tax_category, contact_us_label, contact_us_link, feature_list, available_addons, legacy_options, pwyw_minimum_amount, pwyw_suggested_amount, pwyw_recurring_mode
Customer	has_trialed, extra_information
Payment	line_items, invoice_number
Checkout_Form	thank_you_page_id, conversion_snippets
Email	event, schedule
Broadcast	migrated_from_id, notice_type

Note: Discount_Code and Event already override to_array() and are not affected.

Steps to Reproduce

1. Enable the REST API in Ultimate Multisite settings
2. Call GET /wp-json/wu/v2/site/{id} with valid API credentials
3. Observe that customer_id, membership_id, type, active, etc. are all null
4. Same issue on GET /wp-json/wu/v2/site?domain=example.com

Example API Response (Site)

{
  "id": 0,
  "blog_id": "7",
  "domain": "www.example.com",
  "customer_id": null,
  "membership_id": null,
  "type": null,
  "active": null,
  "template_id": null,
  "featured_image_id": null,
  "categories": null
}

Proposed Fix

Override to_array() in each affected model to call the lazy-loaded getters before calling parent::to_array(). This follows the existing pattern used by Discount_Code and Event models.

I'll submit a PR with the fix shortly.

[superdav42]

Dispatching worker.

• Model: sonnet (opencode/claude-sonnet-4-6
  �[0;32m[SUCCESS]�[0m Resolved sonnet -> opencode/claude-sonnet-4-6 (primary))
• Branch: fix/t469-rest-api-null-meta-fields
• Scope: Fix Base_Model::to_array() to include lazy-loaded meta properties so REST API returns correct values for all 7 affected models
• Attempt: 1 of 1
• Direction: Focus on Base_Model::to_array() at line 840 — ensure lazy-loaded properties fetched from metadata tables are included in serialization

[superdav42]

Worker killed after 14+ minutes with 0 commits (struggle_ratio: 101).

• Model: sonnet (anthropic/claude-sonnet-4-6)
• Branch: bugfix/issue-469-to-array
• Reason: Duplicate workers — PR fix: override to_array() in 7 models to populate lazy-loaded meta properties #470 already existed with commits. Two workers were dispatched to the same issue simultaneously and thrashed with 101 messages and 0 new commits.
• Diagnosis: Workers were confused by the existing PR; likely re-attempting work already done.
• Next action: PR fix: override to_array() in 7 models to populate lazy-loaded meta properties #470 exists with the fix committed. Dispatching a CI-fix worker to address the E2E test failure (pricing table not rendering in free trial checkout flow).

[superdav42]

Both workers killed after 16h51m with 0 commits (struggle_ratio: 118).

• Model: sonnet (anthropic/claude-sonnet-4-6)
• Branch: bugfix/issue-469-to-array
• Reason: Duplicate workers (PIDs 778619 + 778654) — same command dispatched twice, both thrashing with 118 messages and 0 commits over 16+ hours
• Diagnosis: E2E test fix for pricing table element likely requires deeper investigation of the to_array() regression impact on the test environment; sonnet could not resolve it in 16h
• Next action: Re-dispatch single worker at opus tier (2+ failed attempts = escalation threshold met)

[superdav42]

Dispatching worker (escalated to opus after 2 failed sonnet attempts).

• Model: opus (anthropic/claude-opus-4-6)
• Branch: bugfix/issue-469-to-array
• Scope: Fix cypress 'Run Checkout Tests (After Setup)' failure — identify what to_array() override broke the checkout flow and fix it
• Attempt: 3 of 3 (escalated to opus after 2 failed sonnet attempts with 0 commits)
• Direction: Focus on the checkout test spec and how to_array() changes in the 7 models affect checkout flow data structures