test(cart): improve Cart test coverage

[superdav42]

Task t454

Improve test coverage for the Cart class (inc/checkout/class-cart.php).

Current coverage: 61.1% (382 uncovered statements)
Estimated effort: ~4h

Acceptance Criteria

• Additional PHPUnit tests added for Cart class
• Coverage for inc/checkout/class-cart.php increases to ≥80%
• All new tests pass in CI
• No regressions in existing test suite

Context

Part of the ongoing test coverage improvement initiative for Ultimate Multisite.

[superdav42]

Worker Watchdog Kill

Reason: Worker process became idle (CPU below 5% for 300s) — likely completed or hit the OpenCode idle-state bug.

Runtime: 32m 26s

Diagnostic tail: session="Issue #556: test(cart): improve Cart test coverage"; recent_messages=0; newest_part_age=0s; tail=step-start > text:"The issue view returned no content (just a deprecation warning). Let me fetch it directly:" > tool:bash(completed) "Fetch issue 556 with JSON fields" > tool:bash(completed) "Check current git status and branch" > step-finish:tool-calls

This issue has been re-labeled status:available for re-dispatch. The next pulse or manual dispatch will pick it up.

Retry guidance: Post a blocker update describing a changed plan (or newly unblocked dependency), then move the issue back to status:available before re-dispatch.

Automated by worker-watchdog.sh (t1419)

[superdav42]

Worker Watchdog Kill

Reason: Worker process became idle (CPU below 5% for 300s) — likely completed or hit the OpenCode idle-state bug.

Runtime: 32m 26s

Diagnostic tail: session="Issue #556: test(cart): improve Cart test coverage"; recent_messages=0; newest_part_age=0s; tail=step-start > text:"The issue view returned no content (just a deprecation warning). Let me fetch it directly:" > tool:bash(completed) "Fetch issue 556 with JSON fields" > tool:bash(completed) "Check current git status and branch" > step-finish:tool-calls

This issue has been re-labeled status:available for re-dispatch. The next pulse or manual dispatch will pick it up.

Retry guidance: Post a blocker update describing a changed plan (or newly unblocked dependency), then move the issue back to status:available before re-dispatch.

Automated by worker-watchdog.sh (t1419)

[superdav42]

Worker Watchdog Kill

Reason: Worker process became idle (CPU below 5% for 300s) — likely completed or hit the OpenCode idle-state bug.

Runtime: 32m 26s

Diagnostic tail: session="Issue #556: test(cart): improve Cart test coverage"; recent_messages=0; newest_part_age=0s; tail=step-start > text:"The issue view returned no content (just a deprecation warning). Let me fetch it directly:" > tool:bash(completed) "Fetch issue 556 with JSON fields" > tool:bash(completed) "Check current git status and branch" > step-finish:tool-calls

This issue has been re-labeled status:available for re-dispatch. The next pulse or manual dispatch will pick it up.

Retry guidance: Post a blocker update describing a changed plan (or newly unblocked dependency), then move the issue back to status:available before re-dispatch.

Automated by worker-watchdog.sh (t1419)

[superdav42]

Dispatching worker.

• aidevops.sh: v3.1.425
• Model: sonnet (anthropic/claude-sonnet-4-6)
• Branch: feature/cart-test-coverage-556 (existing orphan worktree at /home/dave/Git/ultimate-multisite-feature-cart-test-coverage-556, 2 uncommitted files)
• Scope: Improve Cart class test coverage
• Attempt: 1 of 1
• Direction: Reuse existing orphan worktree. Check uncommitted files for prior work, then write/complete tests.

[superdav42]

Dispatching worker.

• aidevops.sh: v3.1.425
• Model: sonnet (anthropic/claude-sonnet-4-6)
• Branch: feature/cart-test-coverage-556 (existing orphan worktree with partial work)
• Scope: Complete Cart test coverage — phpunit.xml and Cart_Coverage_Test.php already created in worktree
• Attempt: 3 of 3 (prior 2 kills were OpenCode idle-state watchdog, not capability failures)
• Direction: Worktree at /home/dave/Git/ultimate-multisite-feature-cart-test-coverage-556 — commit existing files and complete test coverage

[superdav42]

Worker killed after 54m with 0 commits (struggle_ratio: 290).

• aidevops.sh: v3.1.425
• Model: sonnet (anthropic/claude-sonnet-4-6)
• Branch: feature/cart-test-coverage-556
• Reason: Thrashing — 290 messages, 0 commits after 54 minutes. Third attempt at this issue.
• Diagnosis: Cart test coverage task appears to require deeper codebase understanding than sonnet can achieve in one session. Untracked files (phpunit.xml, Cart_Coverage_Test.php) exist in worktree but worker cannot commit them.
• Next action: Escalate to opus tier per 2+ failure rule.

[superdav42]

Dispatching worker.

• aidevops.sh: v3.1.425
• Model: opus (opencode/claude-opus-4-6) — escalated after 3 failed sonnet attempts
• Branch: feature/cart-test-coverage-556
• Scope: Commit existing untracked files (phpunit.xml, Cart_Coverage_Test.php) and complete Cart test coverage to >=80%
• Attempt: 3 of 3 (escalated to opus after 2+ failed sonnet attempts)
• Direction: Worktree at /home/dave/Git/ultimate-multisite-feature-cart-test-coverage-556 has phpunit.xml and Cart_Coverage_Test.php untracked. Commit them, run tests, fix failures, push PR.