test(host-providers): write tests for Base_Host_Provider

[superdav42]

Task t488

Write unit tests for inc/integrations/host-providers/class-base-host-provider.php.

Current coverage: 16.9% (148 uncovered statements)
Target: ≥80% coverage

Acceptance Criteria

• PHPUnit tests written for Base_Host_Provider class
• Coverage reaches ≥80% for this file
• All tests pass in CI (PHP 8.2, 8.3, 8.4, 8.5)
• No regressions in existing test suite

How

• Create test file at tests/unit/inc/integrations/host-providers/
• Mock external host provider API calls
• Test base class methods and abstract interface

[superdav42]

What was done

• Created tests/WP_Ultimo/Integrations/Host_Providers/Base_Host_Provider_Test.php with 75 PHPUnit unit tests
• Implemented Concrete_Test_Provider test double (concrete subclass with public setters for protected properties)
• Implemented Provider_With_Constants and Provider_With_Features subclasses for feature-specific scenarios
• All external host provider API calls are mocked via concrete test doubles (no real API calls)

Testing Evidence

• Testing level: unit-tested
• Risk classification: low (test files only, no production code changes)
• Results: 75/75 tests pass, 0 failures
• CI: PHP 8.2 ✅ PHP 8.3 ✅ PHP 8.4 ✅ PHP 8.5 ✅

Metric	Before	After
Methods	16.9%	85.29% (29/34)
Lines	~16.9%	96.05% (170/177)

Key decisions

• Used concrete test double subclass rather than PHPUnit mocks (abstract class cannot be mocked directly without implementing all abstract methods)
• Added public setter methods (set_constants, set_optional_constants, set_supports) to the test double to enable white-box testing of protected properties without reflection
• test_connection() and setup_constants() are tested for existence/sanitization only — wp_send_json_success exits in real requests, and WP_Config::inject_wp_config_constant writes to wp-config.php

Files changed

• tests/WP_Ultimo/Integrations/Host_Providers/Base_Host_Provider_Test.php — new (1256 lines, 75 tests)

Blockers

• None

Follow-up needs

• None — coverage target met and exceeded

Released in

• PR t488: test(host-providers): write unit tests for Base_Host_Provider #594 merged 2026-03-27