t517: test(admin): write unit tests for View_Logs and Tax_Rates admin pages

[superdav42]

Write unit tests for:

• inc/admin-pages/class-view-logs-admin-page.php (0% coverage, ~381 lines)
• inc/admin-pages/class-tax-rates-admin-page.php (0% coverage, ~225 lines)

Acceptance Criteria

• Test class instantiation and registration for both pages
• Test all public methods
• Test log viewing and tax rate management logic
• Achieve >50% statement coverage per file
• All tests pass in CI

[superdav42]

Implementation Complete

What was done:

• Added tests/WP_Ultimo/Admin_Pages/View_Logs_Admin_Page_Test.php — 32 tests covering page properties, get_title, get_menu_title, get_labels, get_object, init hook registration, handle_view_logs (return structure, security guard for external files, file contents, default content), handle_save guard conditions, page_loaded, register_scripts, and output_default_widget_payload
• Added tests/WP_Ultimo/Admin_Pages/Tax_Rates_Admin_Page_Test.php — 26 tests covering page properties, get_title, get_menu_title, get_submenu_title, output (action/filter firing, column keys, filter extensibility), register_scripts (registration + enqueue), add_fields_widget (meta box registration, default position), Tax::get_instance()->get_tax_rate_types() integration, and class instantiation

Testing Evidence:

• Level: unit-tested
• All PHP versions (8.2, 8.3, 8.4, 8.5) passed in CI
• CodeRabbit review: passed (1 actionable finding addressed — filter mutation assertion; 5 nitpicks addressed — try/finally hook isolation, tempnam for unique temp files, strengthened assertions)
• PHP syntax validated locally

Key decisions:

• Used try/finally pattern for all hook registrations to prevent test leakage on assertion failures
• Used tempnam() for unique temp log files to avoid parallel-run collisions
• Tested security guard in handle_view_logs (external file path triggers wp_die)
• Tested add_fields_widget via reflection (protected method) to verify meta box registration

Files changed:

• tests/WP_Ultimo/Admin_Pages/View_Logs_Admin_Page_Test.php — new, 32 tests
• tests/WP_Ultimo/Admin_Pages/Tax_Rates_Admin_Page_Test.php — new, 26 tests

Blockers: None

Follow-up needs: None

Merged in: PR #681