Skip to content

fix: network activate reliability — commit orphan worktree changes #873

Description

@superdav42

Summary

An orphan worktree at /home/dave/Git/ultimate-multisite-bugfix-network-activate-reliability (branch bugfix/network-activate-reliability) has 3 uncommitted files with meaningful bugfixes. These need to be committed, pushed, and submitted as a PR.

Uncommitted Changes (already written — do not rewrite)

inc/admin-pages/class-multisite-setup-admin-page.php   +13 lines
inc/admin-pages/class-setup-wizard-admin-page.php      +6/-11 lines
inc/installers/class-base-installer.php                +9/-1 lines

What the changes fix

  1. Installer step routing (class-multisite-setup-admin-page.php:484): Adds explanatory comment block + exit after wp_send_json_error to prevent response leakage when an installer step fails.

  2. Network activate reliability (class-setup-wizard-admin-page.php:153): Replaces activate_plugin() with Multisite_Network_Installer::get_instance()->_install_network_activate() in a try/catch. Fixes silent fallback to single-site activation when OPcache serves stale wp-config.php.

  3. Transaction commit error handling (class-base-installer.php:99): Checks return of $wpdb->query('COMMIT') and returns a WP_Error + log entry on failure.

Implementation

The code is already written. Worker task:

  1. cd /home/dave/Git/ultimate-multisite-bugfix-network-activate-reliability
  2. Verify: git diff --stat shows the 3 files above
  3. git add inc/admin-pages/class-multisite-setup-admin-page.php inc/admin-pages/class-setup-wizard-admin-page.php inc/installers/class-base-installer.php
  4. git commit -m "fix: network activate reliability — routing, OPcache activation, commit error handling"
  5. git push -u origin bugfix/network-activate-reliability
  6. Create PR to main with Resolves #<this-issue>

Do not rewrite the changes — they are already correct. Just commit, push, and create the PR.

Verification

Run gh pr checks <PR_NUMBER> --repo Ultimate-Multisite/ultimate-multisite — all checks should pass. The changes are defensive (error checking + reliability fixes) with no happy-path behavior change.


aidevops.sh v3.8.40 plugin for OpenCode v1.4.6 with claude-sonnet-4-6 spent 5m and 11,175 tokens on this as a headless worker.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingorigin:workerAuto-created by pulse labelless backfill (t2112)status:in-progressWorker actively running

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions