Skip to content

GH#1013: Replace sed dependency with pure PHP in replace_db_prefix() #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 1 commit into from
Apr 30, 2026
Merged

GH#1013: Replace sed dependency with pure PHP in replace_db_prefix() #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions inc/site-exporter/mu-migration/includes/commands/class-mu-migration-import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,6 @@ public function tables($args = [], $assoc_args = [], $verbose = true) {

$wu_site_exporter_site_id = $this->assoc_args['blog_id'];

// Terminates the script if sed is not installed.
$this->check_for_sed_presence(true);

// Replaces the db prefix and saves back the modifications to the sql file.
if ( ! empty($this->assoc_args['new_prefix']) ) {
$this->replace_db_prefix($filename, $this->assoc_args['old_prefix'], $this->assoc_args['new_prefix']);
Expand Down Expand Up @@ -676,7 +673,11 @@ private function create_new_site($meta_data) {
}

/**
* Replaces the db_prefix with a new one using sed.
* Replaces the db_prefix with a new one using pure PHP string replacement.
*
* Processes the SQL file line by line to avoid loading the entire file into
* memory, and writes output to a temporary file before replacing the original.
* Works in both CLI and web/AJAX contexts (no sed dependency).
*
* @param string $filename The filename of the sql file to which the db prefix should be replaced.
* @param string $old_db_prefix The db prefix to be replaced.
Expand All @@ -686,7 +687,7 @@ private function replace_db_prefix($filename, $old_db_prefix, $new_db_prefix) {
$new_prefix = $new_db_prefix;

if ( ! empty($new_prefix) ) {
$mysql_chunks_regex = [
$mysql_keywords = [
'DROP TABLE IF EXISTS',
'CREATE TABLE',
'LOCK TABLES',
Expand All @@ -697,20 +698,33 @@ private function replace_db_prefix($filename, $old_db_prefix, $new_db_prefix) {
'REFERENCES',
];

// build sed expressions
$sed_commands = [];
foreach ( $mysql_chunks_regex as $regex ) {
$sed_commands[] = "s/{$regex} `{$old_db_prefix}/{$regex} `{$new_prefix}/g";
}
$temp_filename = $filename . '.tmp';
$input = fopen($filename, 'r');
$output = fopen($temp_filename, 'w');

foreach ( $sed_commands as $sed_command ) {
$full_command = "sed '$sed_command' -i $filename";
$sed_result = \WP_CLI::launch($full_command, false, false);
if ( false === $input || false === $output ) {
\WP_CLI::warning(__('Could not open SQL file for prefix replacement', 'mu-migration'));
if ( $input ) {
fclose($input);
}
return;
}

if ( 0 !== $sed_result ) {
\WP_CLI::warning(__('Something went wrong while running sed', 'mu-migration'));
while ( false !== ($line = fgets($input)) ) {
foreach ( $mysql_keywords as $keyword ) {
$line = str_replace(
$keyword . ' `' . $old_db_prefix,
$keyword . ' `' . $new_prefix,
$line
);
}
fwrite($output, $line);
}

fclose($input);
fclose($output);

rename($temp_filename, $filename);
}
}

Expand Down
Loading